Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): improve player bg color #3018

Merged
merged 3 commits into from
Mar 11, 2025
Merged

fix(mobile): improve player bg color #3018

merged 3 commits into from
Mar 11, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Mar 11, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 2:30am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 2:30am

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: improve color gradient handling in player module

Change Summary:
Refactor color handling in player hooks and screen components

Code Review:

Code Review

1. File: apps/mobile/src/modules/player/hooks.ts

  • Line 6:
    The updated gradientColors are now set to an array of the same shadedColor for both elements ([shadedColor, shadedColor]). This removes the gradient and makes both colors identical, which could be unintended based on the previous functionality. If this is intentional, it should be justified in the PR description to avoid ambiguity. Otherwise, restore the gradient by having different shades for the two colors (e.g., one lightened and one darkened).

2. File: apps/mobile/src/screens/player.tsx

  • Line 15:
    The usePlayerScreenContext hook is imported but not included in the accompanying PR changes (with regard to its declaration or usage). Ensure this hook is implemented correctly in ../modules/player/context before merging this PR, or explain its functionality in the PR description if it was previously implemented.

  • Line 103:
    The cn function used here for class concatenation is not declared or imported in the file. If cn is a utility function being used across the codebase, ensure it is correctly imported in this file (e.g., import { cn } from "../utils/cn"). Missing imports will cause runtime errors.


Summary

Three changes require attention:

  1. Clarify or fix gradient behavior in hooks.ts (Line 6).
  2. Verify the implementation and existence of usePlayerScreenContext before merging.
  3. Ensure the cn function is properly imported in player.tsx.

Make these corrections or provide additional clarification for the changes made.

@hyoban hyoban changed the title fix(mobile): improve payer bg color fix(mobile): improve player bg color Mar 11, 2025
@hyoban hyoban enabled auto-merge (squash) March 11, 2025 02:29
@hyoban hyoban merged commit f991e91 into dev Mar 11, 2025
11 checks passed
@hyoban hyoban deleted the fix/improve-player-color branch March 11, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant