Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mobile staging and dev icons #3375

Merged
merged 3 commits into from
Mar 31, 2025
Merged

feat: mobile staging and dev icons #3375

merged 3 commits into from
Mar 31, 2025

Conversation

DIYgod
Copy link
Member

@DIYgod DIYgod commented Mar 31, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 10:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2025 10:44am

@DIYgod DIYgod requested a review from Copilot March 31, 2025 10:22
@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: improve environment handling and configuration

Change Summary:
Refactored environment handling across desktop and mobile apps. Introduced better mode handling, added new icons, and updated configurations for different profiles in mobile. This enhances clarity and maintainability in environment indicators and configurations.

Code Review:

Code Review

Issues Requiring Change Requests:

  1. File: apps/mobile/app.config.ts
    Line: iconPathMap initialization (lines 6–16)
    Issue: The key "ios-simulator" in the iconPathMap is inconsistent with other environment names ("production", "development", etc.). It would be better to rename it to simulator (or similar) for consistency across environment keys. The inconsistency could cause confusion when maintaining or extending the code.

  2. File: apps/mobile/eas.json
    Line: "ios-simulator" (lines 9–12)
    Issue: Similar to the previous issue, the environment name "ios-simulator" in eas.json does not align with other environment names. Updating it to simulator (or any consistent naming scheme) will improve cohesion and readability.

  3. File: apps/desktop/src/renderer/src/modules/settings/tabs/about.tsx
    Line: 31
    Issue: The expression MODE !== ModeEnum.production uses strict inequality for comparing the environment. The ModeEnum might contain different values for similar modes (e.g., production and prod) depending on future extensions. Consider using a helper function like isProductionMode(MODE) to centralize and simplify mode comparison.


If these issues are addressed, the PR should be ready for further review.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces mobile and environment improvements by updating icon handling in the mobile app configuration and streamlining environment display logic for desktop.

  • Updated environment info in the utils package to include the MODE constant.
  • Revised mobile app configuration to use different icons based on the environment profile.
  • Modified desktop UI components to display environment information using the new MODE constant.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

File Description
packages/utils/src/environment.ts Added MODE import and output to display current mode in environment details
apps/mobile/app.config.ts Replaced a static icon path with a mapping to support multiple profiles
apps/desktop/src/renderer/src/modules/settings/tabs/about.tsx Updated environment display logic using the MODE constant
apps/desktop/src/renderer/src/modules/app/EnvironmentIndicator.tsx Replaced inline mode retrieval with the imported MODE constant
Files not reviewed (1)
  • apps/mobile/eas.json: Language not supported

@DIYgod DIYgod changed the title Feature/mobile icons feat: mobile staging and dev icons Mar 31, 2025
@DIYgod DIYgod marked this pull request as ready for review March 31, 2025 13:42
@DIYgod DIYgod merged commit 5dfd70f into dev Mar 31, 2025
12 of 13 checks passed
@DIYgod DIYgod deleted the feature/mobile-icons branch March 31, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant