Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-react-app build process broken #23

Closed
czycha opened this issue Mar 13, 2018 · 0 comments
Closed

create-react-app build process broken #23

czycha opened this issue Mar 13, 2018 · 0 comments

Comments

@czycha
Copy link

czycha commented Mar 13, 2018

See Predicate issue #10

I'm using json-rules-engine-simplified paired with react-jsonschema-form-conditionals for a web app that I'm building using create-react-app.

The form works perfectly well when in development mode. However, I'm unable to build the app for deployment because create-react-app does not minify ES6 features. This issue affects this module because it depends on Predicate, which uses ES6.

I spoke with the maintainer of that project, and they are hoping to stick with ES6 as their entry point. So I'm posting here to suggest importing predicate/dist/predicate instead of just predicate. This file is just Predicate transpiled to ES5.

The affected files are:

  • src/checkField.js
  • src/validation.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant