-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update uvdata tutorial #1534
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 63 63
Lines 21758 21758
=======================================
Hits 21743 21743
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work on the todos. I found a couple other minor things in my read through.
the physical orientation of the dipole can also be used (e.g. "nn" or "ee). | ||
UVData: Phasing | ||
--------------- | ||
Phasing/unphasing data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a short paragraph describing the idea of phasing, mentioning the types of phase centers and pointing to the phasing memo for more information.
Change the order and clean up initial text in the UVData tutorial
Rearrange the existing code snippits into a more sensible order
for more information, see https://pre-commit.ci
get rid of the "file conversion" section
15a863b
to
ec08d90
Compare
Description
Updates to the tutorial to make it more pedagogical and more consistent with modern pyuvdata
Motivation and Context
Our tutorial was not well-ordered from a pedagogical point of view (e.g. beginning with files conversions). Subsections have been reordered to (hopefully) make a more useful document for a new user to sit down and work through. References to older versions of pyuvdata have also largely been removed.
Closes #1341
Types of changes
Checklist:
Documentation change checklist: