-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to no EPR/PPS so its opt in #2073
Conversation
Some chargers have funky PPS. Plus some do not want EPR be default (even though 28V is safe by designer on PinecilV2). So take the safest option by default and make it opt-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my own humble two cents...
Probably it will be worth mentioning somewhere in the docs, so I will try not to forget to address this in the future.
I understand the risk having this on by default, but one of the main features (not available with any other supported hardware) is full EPR/28V mode support, but having this off by default will probably raise a lot of questions from freshly new users who is getting Pinecil V2 for this reason only. :/
@@ -93,7 +93,7 @@ static const SettingConstants settingsConstants[(int)SettingsOptions::SettingsOp | |||
{ 0, 6, 1, 1}, // LOGOTime | |||
{ 0, 1, 1, 0}, // CalibrateCJC | |||
{ 0, 1, 1, 0}, // BluetoothLE | |||
{ 0, 2, 1, 1}, // USBPDMode | |||
{ 0, 2, 1, 0}, // USBPDMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... Definitely looks more safer, especially when users connect PD-compatible supported hardware to not-so-reliable PD-kinda power sources.
Yeah it's a trade off, between safest and what people expect. |
I see on the Pine64 wiki this note: "Tentatively", the Pinecil V2 also "unofficially" supports 28V-140W EPR/PD3.1 USB-C chargers with certified EPR 240W USB-C cables. Also, with my Pinecil V2 (FW 2.22), the recommended Rocoren 140W/28V USB GaN Charger and a certified PD 3.1/240W silicon USB-C cable, I'm experiencing occasional/inconsistent reboots while soldering, which is a very annoying issue. Could these occasional (but still frequent) reboots be caused by a limited support of the 28V? |
I do not maintain the wiki, nor contribute to it. As far as IronOS and manufacturing of the Pinecilv2 is concerned EPR is supported. Its just not warranted by the store as:
I don't recommend a specific charger, because compatibility is a tricky thing. (Vendors change out parts and specs without changing part numbers). Resetting is not expected, and it is best to open a specific issue or discussion to track this to look into what the cause is. The main issue I've personally seen has been not perfect-fit on usb-c connectors causing them to wiggle and cause communications to drop out. EPR is a lot more sensitive to this than normal PD. |
@Wuthoqquan, just for your information (which turned out to be the news for me as well by the way), official Pine64 wiki site is marked as read-only (so some pages and/or information may be out-of-dated there indeed), but now it's replaced by up-to-dated hugo-based site. If you see that some information, specifications or any other data should be updated or be more clear there, then feel free to submit a bug report (aka "issue"), or even open pull-request to update the documentation right in the documentation source repo, since the community is very friendly (because Pine64 and its projects is the community :) |
Some chargers have funky PPS.
Plus some do not want EPR be default (even though 28V is safe by designer on PinecilV2).
So take the safest option by default and make it opt-in
Request from Pinecil Chat - dsimic
What is the new behavior (if this is a feature change)?
Other information: