Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if local tracker store is the correct one #3697

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jun 4, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from tmbo June 4, 2019 13:38
@wochinge wochinge marked this pull request as ready for review June 4, 2019 13:38
@tmbo
Copy link
Member

tmbo commented Jun 4, 2019

mhm, why does it only work with the sqllite tracker store though?

@wochinge
Copy link
Contributor Author

wochinge commented Jun 5, 2019

Because we use the SQLite tracker store to "stream" the events to Rasa X.

@tmbo
Copy link
Member

tmbo commented Jun 5, 2019

Ok I see. I think this quickfix works then. But we should really create a proper sqllite eventstream rather than using the trackerstore. I'll create a separate issue for it.

@wochinge wochinge merged commit 8f15261 into master Jun 5, 2019
@wochinge wochinge deleted the require-sqlite-tracker-store-locally branch June 5, 2019 08:45
@tmbo
Copy link
Member

tmbo commented Jun 5, 2019

followup issue #3702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants