Fixed the issue #88 -- when the route changes where the old route is … #119
Conversation
…ute is longer than the new route
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 85.5% 85.57% +0.07%
==========================================
Files 5 5
Lines 200 201 +1
==========================================
+ Hits 171 172 +1
Misses 29 29
Continue to review full report at Codecov.
|
|
Can we get the PR reviewed? |
| @@ -119,6 +119,42 @@ class ReSwiftRouterUnitTests: QuickSpec { | |||
| expect(action1Correct).to(beTrue()) | |||
| expect(action2Correct).to(beTrue()) | |||
| } | |||
|
|
|||
| it("generates a Change action on the last common subroute, also for routes of different length, old route is longer than the new one") { | |||
There was a problem hiding this comment.
This is quite a mouthful :) I suggest to rename the three cases to:
it("generates a Change on the last common subroute for routes of same length") { ... }
it("generates a Change on the last common subroute when new route is longer than the old route") { .. }
it("generates a Change on the last common subroute when the new route is shorter than the old route") { ... }Maybe you can come up with a shared context that fits, like context("changing non-root elements") or so.
There was a problem hiding this comment.
@DivineDominion - changed the test names as you have suggested.
|
@kmmraj Thanks a lot for contributing to ReSwift! We've invited you to join Generated by 🚫 dangerJS |
|
Merged. Thanks for the PR! @kmmraj |
I will be more than happy to join. |
|
@DivineDominion Since this is a subtle change fundamental to routing , can we consider creating a new release , so the change is reflected , when I install ReSwift via Cocoapods? |
Fixed the issue #88 -- when the route changes where the old route is longer than the new route
Refer to the issue#88 for the complete explanation of the issue.
This issue is fixed in ReKotlin-Router as well, refer here for more details.