You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
phbernard
changed the title
Consider the content of inline pictures as base64, not as file name
Consider the content of inline pictures as base64 or as file name
Dec 8, 2016
Currently, the lib is expecting a file name as the
content
when the type isinline
:This is counter-intuitive. The two relevant syntax should be:
File name:
Base 64:
However, the current behavior is explicitly tested (https://github.com/RealFaviconGenerator/rfg-api/blob/master/test/test.js#L292). It must be safer to accept both types of
content
, even if this is not pretty:and:
This issue is related to RealFaviconGenerator/realfavicongenerator#236
The text was updated successfully, but these errors were encountered: