Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 'parameters' not to be optional and added a schema to check the required model_type instead of in the setup method #319

Conversation

jeremychoi
Copy link
Collaborator

No description provided.

@jeremychoi jeremychoi requested a review from a team as a code owner March 7, 2025 08:31
Copy link
Collaborator

@ccronca ccronca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Just to clarify: with the check in the code, Rapidast would stop if the model_type is missing. But with this approach, since it doesn't fail on schema validation errors (for now), it'll keep going even if the key is missing

@jeremychoi jeremychoi merged commit 18fa8b6 into RedHatProductSecurity:development Mar 10, 2025
5 checks passed
ccronca pushed a commit to ccronca/rapidast that referenced this pull request Mar 17, 2025
… required model_type instead of in the setup method (RedHatProductSecurity#319)

* fixed 'parameters' not to be optional and added a schema

* removed unused 'Optional' from import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants