feat: [Traits] Implements a GDScript Trait system #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just found a new bug with the gutter icons, from what I can see if the trait (.gdt) has a function on the same line than a virtual function inside the script (.gd) where the trait is used, the function from the script is "replaced" by the function in the trait (.gdt) file. I'm already working on a fix :) What we have right now What we should have |
Credit @Ward727a - Fixed a bug when 2 functions (one from trait, and one from other scipt) was one the same line: The gutter icon for virtual function wasn't shown. - Did a little optimization on the "get_function_names_recursively" function (using Vector and not HashMap) this allow us to gain ~10% in time when running (HashMap average ~= 9.8µs / Vector average ~= 8.8µs).
decryptedchaos
force-pushed
the
feature/traits-fix
branch
from
69df8e6 to
ed49262
Compare
mcdubhghlas
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the following PR Authored by @SeremTitus
I tried my best to get this to preserve your signature in the log but i was having a lot of trouble getting it to squash. So i'll just credit you here.
Add Trait System to GDScript godotengine/godot#97657
The Redot team have added some improvements and bug fixes:
Credit to @Ward727a
[FIX] Traits have proper template on creation
[BUG] Trait creation was not checking if a trait of the same name already existed.
[BUG] Gutter marker for base class functions ( _ready & _process) for Traits