-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Adds Custom Tabs to support in-app browser URL destinations #2035
Merged
Merged
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
8a0c1d0
Adds an optional previewImageLoader parameter.
JayShortway d26ee92
Adds and uses aspect ratio to aid layout when one axis is Fit.
JayShortway 7b18c1d
Fixes cyclomatic complexity.
JayShortway 313af7e
Fixes the gradient previews.
JayShortway a6959c2
Marks DrawablePainter as experimental.
JayShortway a4d626b
Handles gradient percentages in the 0..100 range.
JayShortway 1adb3e8
Splits restore logic to handleRestorePurchases and calls it from hand…
JayShortway 734faad
Calls handlePackagePurchase from handleAction.
JayShortway be64ae6
Calls closePaywall from handleAction.
JayShortway 09be9d4
Moves click handling to the Composable for easier navigation handling.
JayShortway 6e9a0c5
Fixes PaywallActionTests.
JayShortway f57414e
Handles URL button destinations.
JayShortway 7410ee4
Updates compose-bom to 2024.09.00.
JayShortway 609550e
Fixes Markdown consuming all click actions, even without links.
JayShortway b115f58
Adds another strikethrough preview.
JayShortway 8908a6b
Fixes PaywallActionTests.
JayShortway 1d10bad
Merge branch 'pw2-fix-text-button-click-consumption' into pw2-button-…
JayShortway 0d41211
Merge branch 'main' into pw2-gradient-percent-scale
JayShortway 727d7e8
Merge branch 'pw2-gradient-percent-scale' into pw2-fix-text-button-cl…
JayShortway 3065b4f
Merge branch 'pw2-fix-text-button-click-consumption' into pw2-button-…
JayShortway 87bc1a9
Adds Custom Tabs to support in-app browser URL destinations.
JayShortway 460dff3
Merge branch 'main' into pw2-fix-text-button-click-consumption
JayShortway 97a439d
Merge branch 'pw2-fix-text-button-click-consumption' into pw2-button-…
JayShortway 0d2f2f0
Merge branch 'pw2-button-actions' into pw2-in-app-browser
JayShortway cc1b11a
Merge branch 'main' into pw2-button-actions
JayShortway 40c3b61
Merge branch 'pw2-button-actions' into pw2-in-app-browser
JayShortway 3684f8b
Uncomments the same thing again.
JayShortway 43c0725
Merge branch 'pw2-button-actions' into pw2-in-app-browser
JayShortway a0be258
Fixes tests.
JayShortway 2ee2941
Merge branch 'main' into pw2-button-actions
JayShortway 6eb73b4
Merge branch 'pw2-button-actions' into pw2-in-app-browser
JayShortway e47e725
Merge branch 'main' into pw2-in-app-browser
JayShortway e5471b0
Merge branch 'main' into pw2-in-app-browser
JayShortway e1d2ed4
Merge branch 'main' into pw2-in-app-browser
JayShortway 63ce86f
Merge branch 'main' into pw2-in-app-browser
JayShortway b0f547f
Catches known exceptions only.
JayShortway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be very light on runtime dependencies, which decreases the risk of binary incompatibilities.