[Paywalls V2] Update Stack to handle property overrides #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the title
vegaro
approved these changes
Nov 13, 2024
| // Without compositingGroup(), the shadow is applied to the stack's children as well. | ||
| view.compositingGroup().shadow(shadow: shadow) | ||
| } | ||
| .padding(viewModel.margin) | ||
| .padding(style.margin) |
There was a problem hiding this comment.
how does this interact with line 75? Does it override it?
There was a problem hiding this comment.
@vegaro This does look very unclear without context 😅 SwiftUI applies things on top of each other so...
- Line 75 adds padding to the view to make it bigger
- Line 78 adds background color (which is applied to the whole bigger view)
- This line (85) adds
paddingagain (but without background color) so it acts as margin
RevenueCatUI/Templates/Components/Stack/StackComponentViewModel.swift
Outdated
Show resolved
Hide resolved
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-5-soft-decoding-error
branch
from
26cd38e to
f16fa6e
Compare
Base automatically changed from
paywalls-v2/schema-rework-part-5-soft-decoding-error
to
main
November 13, 2024 12:52
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-6-stack-selection-state
branch
from
9fc70a4 to
05ca788
Compare
joshdholtz
deleted the
paywalls-v2/schema-rework-part-6-stack-selection-state
branch
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Do what Stack version of #4417
Description
Stacks can now use overrides based on:
Bonus
Implements a new system for handling UI component state overrides based on different
presentation contexts (screen size, selection state, etc).
See #4477 for what this change looks like on when used on a new component (it was super clean when adding it to image)
Key changes:
PresentedPartialprotocol for component combining behavior/propertiesPresentedOverrides<T>struct to handle:The system follows a hierarchical override pattern where more specific states (like selection) take precedence over more general ones (like screen size). Screen conditions cascade (expanded includes medium + compact overrides).