Refactor Order/Slot models #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
force-pushed
the
refactor-order-model
branch
4 times, most recently
from
70b9b9f to
9008e98
Compare
KoalaSat
commented
Aug 15, 2024
| @@ -102,9 +98,6 @@ const BookPage = (): JSX.Element => { | |||
| > | |||
| <Box sx={{ maxWidth: '18em', padding: '0.5em' }}> | |||
| <MakerForm | |||
| onOrderCreated={(id) => { | |||
| navigate(`/order/${id}`); | |||
| }} | |||
| onOrderCreated={(shortAlias, id) => { | ||
| setCurrentOrderId({ id, shortAlias }); | ||
| navigate(`/order/${shortAlias}/${id}`); | ||
| }} | ||
| disableRequest={matches.length > 0 && !showMatches} | ||
| collapseAll={showMatches} | ||
| onSubmit={() => { |
KoalaSat
commented
Aug 15, 2024
| export type { Book, PublicOrder } from './Book.model'; | ||
| export type { Slot } from './Garage.model'; | ||
| export type { Language } from './Settings.model'; | ||
| export type { Favorites } from './Favorites.model'; | ||
| export type { Contact, Info, Version, Origin } from './Coordinator.model'; |
| @@ -1,7 +1,5 @@ | |||
| import React, { useState, useEffect, useContext } from 'react'; | |||
| @@ -20,7 +20,6 @@ interface ChatPromptProps { | |||
| loadingReceived: boolean; | |||
| @@ -7,7 +7,6 @@ interface Props { | |||
| order: Order; | |||
| @@ -36,7 +36,6 @@ interface Props { | |||
| makerHashId: string; | |||
Reckless-Satoshi
force-pushed
the
main
branch
2 times, most recently
from
9054b87 to
f9244e1
Compare
KoalaSat
force-pushed
the
refactor-order-model
branch
from
afe699a to
a92ca62
Compare
|
Tested and working. And several minor bugs fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes on this PR:
CurrentOrder(visited order on the order page) andActiveOrder/LastOrder(orders associated to the slot)...UpdatedAtvariables and keep onlyslotUpdatedAtandfederationUpdatedAtChecklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.