Replace snort by njump links #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaSat
reviewed
Nov 8, 2024
| @@ -1,5 +1,6 @@ | |||
| import React, { useContext, useEffect, useState } from 'react'; | |||
| import { useTranslation } from 'react-i18next'; | |||
| import { isMobile } from 'react-device-detect'; | |||
There was a problem hiding this comment.
The /frontend folder is platform agnostic and we have a more specific way to define were it's being run (web/mobile/desktop/self-hosting).
For this purpose, better if you do client === 'mobile' (example)
There was a problem hiding this comment.
@KoalaSat, can you please check again?
femelo
force-pushed
the
1288-replace-snort-by-njump-links
branch
from
5c3c267 to
5086547
Compare
KoalaSat
approved these changes
Nov 9, 2024
|
Looks good! Merging as is! Please submit a 20K Sats invoice for a small DevFund tip. |
|
@Reckless-Satoshi, if I may, before accepting the tip I will fix my channel: it is on a Megalith node operating at high fees. |
|
Of course, just post it here when ready and make sure to make one with a long expiration time (+1 week) so we catch it in time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1288
This PR implements the following modifications:
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.