Prepare version 5.2.0 #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikwat CI seems to fail. I'd love to get some help from some more active Ruby developers in getting this to work with Rails 5 and only the other supported versions. |
|
@wldcordeiro Strange that CI passed on master 24 days ago... let me try to figure out what's going on. |
|
@wldcordeiro CI passing now! |
|
Sorry to bug you @wldcordeiro, but I'd really like to move this forward. Please take another look. |
wldcordeiro
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
Thanks a ton @mikwat I had to get rolify setup on my laptop again to get the rubygems stuff prepped but I'll bring this in and release. 😄
|
Great, thanks @wldcordeiro! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a lot of changes since 5.1.0 There was an attempt at this back in 2016: #405 Hoping to see it through this time.
@wldcordeiro