Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025.3.2-ruru-1.3.1 #206

Merged
merged 12 commits into from
Mar 10, 2025
Merged

2025.3.2-ruru-1.3.1 #206

merged 12 commits into from
Mar 10, 2025

Conversation

Ruruke
Copy link
Owner

@Ruruke Ruruke commented Mar 10, 2025

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

github-actions bot and others added 12 commits March 10, 2025 10:22
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
* wip

* wip

* wip

* test

* wip rollup pluginでsearchIndexの情報生成

* wip

* SPDX

* wip: markerIdを自動付与

* rollupでビルド時・devモード時に毎回uuidを生成するように

* 開発サーバーでだけ必要な挙動は開発サーバーのみで

* 条件が逆

* wip: childrenの生成

* update comment

* update comment

* rename auto generated file

* hashをパスと行数から決定

* Update privacy.vue

* Update privacy.vue

* wip

* Update general.vue

* Update general.vue

* wip

* wip

* Update SearchMarker.vue

* wip

* Update profile.vue

* Update mute-block.vue

* Update mute-block.vue

* Update general.vue

* Update general.vue

* childrenがduplicate key errorを吐く問題をいったん解決

* マーカーの形を成形

* loggerを置きかえ

* とりあえず省略記法に対応

* Refactor and Format codes

* wip

* Update settings-search-index.ts

* wip

* wip

* とりあえず不確定要因の仮置きidを削除

* hashの生成を正規化(絶対パスになっていたのを緩和)

* pathの入力を省略可能に

* adminでもパス生成できるように

* Update settings-search-index.ts

* Update privacy.vue

* wip

* build searchIndex

* wip

* build

* Update general.vue

* build

* Update sounds.vue

* build

* build

* Update sounds.vue

* 🎨

* 🎨

* Update privacy.vue

* Update privacy.vue

* Update security.vue

* create-search-indexを多少改善

* build

* Update 2fa.vue

* wip

* 必ずtransformCodeCacheを利用するように, キャッシュの明確な受け渡しを定義

* キャッシュはdevServerでなくても更新

* Revert "wip"

This reverts commit 41bffd3.

* inlining

* wip

* Update theme.vue

* 🎨

* wip normalize

* Update theme.vue

* キャッシュのパス変換

* build

* wip

* wip

* Update SearchMarker.vue

* i18n.ts['key'] の形式が取り出せない問題のFix

* build

* 仮でpath入れ

* 必ず絶対パスが使われるように

* wip

* 🎨

* storybookビルド時はcreateSearchIndexをしない

* inliningの構造化

* format code

* Update index.vue

* wip

* wip

* 🎨

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* clean up

* wip

* wip

* wip

* Update rollup-plugin-unwind-css-module-class-name.test.ts

* Update navbar.vue

* clean up

* wip

* wip

* wip

* wip

* wip

* Update preferences-backups.vue

* Update common.ts

* Update preferences.ts

* wip

* wip

* wip

* wip

* Update MkPreferenceContainer.vue

* Update MkPreferenceContainer.vue

* Update MkPreferenceContainer.vue

* enhance: 検索で上下矢印を使用することで検索結果を移動できるように

* Update main-boot.ts

* refactor

* wip

* Update sounds.vue

* fix(frontend): PageWindowでSearchMarkerが動作するように

* enhance(frontend): SearchMarkerの点滅を一定時間で止める

* wip

* lint fix

* fix: 子要素監視が抜けていたのを修正

* アニメーションの回数はCSSで制御するように

* refactor

* enhance(frontend): 検索インデックス作成時のログを削減

* revert

* fix

* fix

* Update preferences.ts

* Update preferences.ts

* wip

* Update preferences.ts

* wip

* 🎨

* wip

* Update MkPreferenceContainer.vue

* wip

* Update preferences.ts

* wip

* Update preferences.ts

* Update preferences.ts

* wip

* wip

* Update preferences.ts

* wip

* wip

* Update preferences.ts

* Update CHANGELOG.md

* Update preferences.ts

* Update deck-store.ts

* deckStoreをdefaultStoreに統合

* wip

* defaultStore -> store

* Update profile.ts

* wip

* refactor

* wip: plugin

* plugin

* plugin

* plugin

* Update plugin.ts

* wip

* Update plugin.vue

* Update preferences.ts

* Update main-boot.ts

* wip

* fix test

* Update plugin.vue

* Update plugin.vue

* Update utility.ts

* wip

* wip

* Update utility.ts

* wip

* wip

* clean up

* Update utility.ts

---------

Co-authored-by: tai-cha <dev@taichan.site>
Co-authored-by: taichan <40626578+tai-cha@users.noreply.github.com>
Co-authored-by: kakkokari-gtyih <67428053+kakkokari-gtyih@users.noreply.github.com>
* enhnace(frontend): 文字列比較のためのローマナイズを強化

* docs

* fix

* fix

* fix

* comment

* wanakanaの初回ロードをコンポーネント内に移動

* comment

* fix

* add tests

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Ruruke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the Misskey frontend and backend to version 2025.3.2. It includes several bug fixes and enhancements, including improved settings management with automatic backups, a fix for incorrect user ID handling during DB migrations, and a correction for the user.featured column. The frontend sees a shift from using defaultStore to store and prefer for managing application state and preferences, along with new translations for settings-related features.

Highlights

  • Version Update: Updates the Misskey frontend and backend to version 2025.3.2-ruru-1.3.1.
  • Settings Management: Improves settings management in the client, including automatic backups and profile-specific configurations.
  • Database Fixes: Fixes an issue with incorrect user ID handling during DB migrations and corrects the user.featured column to ensure it's not a JSON string.
  • Frontend Refactor: Replaces usages of defaultStore with store and prefer in the frontend to better manage application state and preferences.
  • Localization: Adds new Japanese translations for settings-related features, enhancing the user experience for Japanese speakers.

Changelog

Click here to see the changelog
  • CHANGELOG.md
    • Adds entries for version 2025.3.2, including general improvements, client-side settings management enhancements, and a server-side fix for the user.featured column.
    • Fixes: user.featured列が状況によってJSON文字列になっていたのを修正
  • locales/index.d.ts
    • Adds new locale strings related to preferences, accessibility, and settings profiles.
    • Adds new locale strings related to automatic backups.
  • locales/ja-JP.yml
    • Adds Japanese translations for new settings-related features, including preferences profiles and automatic backups.
  • package.json
    • Updates the Misskey version to 2025.3.2-ruru-1.3.1.
  • packages/backend/migration/1741424411879-user-featured-fixup.js
    • Adds a new database migration to fix the user.featured column, ensuring it contains the correct data type.
  • packages/backend/src/core/activitypub/models/ApPersonService.ts
    • Modifies the ApPersonService to correctly handle the user.featured column when retrieving ActivityPub person data.
  • packages/frontend/.storybook/preview.ts
    • Updates Storybook configuration to use the new store and prefer modules, replacing defaultStore.
    • Resets the store during Storybook stories.
  • packages/frontend/lib/rollup-plugin-unwind-css-module-class-name.test.ts
    • Updates tests to use the new store module instead of defaultStore.
  • packages/frontend/package.json
    • Adds wanakana as a dependency.
  • packages/frontend/src/boot/common.ts
    • Modifies the common boot file to use the new store and prefer modules for managing application state and preferences.
    • Loads default light and dark themes.
    • Implements preferences migration.
  • packages/frontend/src/boot/main-boot.ts
    • Updates the main boot file to use the new store and prefer modules.
    • Launches plugins from preferences.
  • packages/frontend/src/components/MkAutocomplete.vue
    • Updates MkAutocomplete to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkCaptcha.vue
    • Updates MkCaptcha to use the new store module for managing application state.
  • packages/frontend/src/components/MkChart.vue
    • Updates MkChart to use the new store module for managing application state.
  • packages/frontend/src/components/MkCode.core.vue
    • Updates MkCode.core to use the new store module for managing application state.
  • packages/frontend/src/components/MkCode.vue
    • Updates MkCode to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkContainer.vue
    • Updates MkContainer to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkContextMenu.vue
    • Updates MkContextMenu to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkCropperDialog.vue
    • Updates MkCropperDialog to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkDateSeparatedList.vue
    • Updates MkDateSeparatedList to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkDeleteScheduleEditor.vue
    • Updates MkDeleteScheduleEditor to use the new store module for managing application state.
  • packages/frontend/src/components/MkDrive.folder.vue
    • Updates MkDrive.folder to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkDrive.vue
    • Updates MkDrive to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkEmojiPicker.vue
    • Updates MkEmojiPicker to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkEmojiPickerDialog.vue
    • Updates MkEmojiPickerDialog to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkFoldableSection.vue
    • Updates MkFoldableSection to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkFolder.vue
    • Updates MkFolder to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkFollowButton.vue
    • Updates MkFollowButton to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkGalleryPostPreview.vue
    • Updates MkGalleryPostPreview to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkGoogle.vue
    • Updates MkGoogle to use the new store module for managing application state.
  • packages/frontend/src/components/MkHeatmap.vue
    • Updates MkHeatmap to use the new store module for managing application state.
  • packages/frontend/src/components/MkHorizontalSwipe.vue
    • Updates MkHorizontalSwipe to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkImgWithBlurhash.vue
    • Updates MkImgWithBlurhash to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkInstanceTicker.vue
    • Updates MkInstanceTicker to use the new store module for managing application state.
  • packages/frontend/src/components/MkLaunchPad.vue
    • Updates MkLaunchPad to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkMediaAudio.vue
    • Updates MkMediaAudio to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkMediaImage.vue
    • Updates MkMediaImage to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkMediaList.vue
    • Updates MkMediaList to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkMediaVideo.vue
    • Updates MkMediaVideo to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkMention.vue
    • Updates MkMention to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkModal.vue
    • Updates MkModal to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkNote.vue
    • Updates MkNote to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkNoteDetailed.vue
    • Updates MkNoteDetailed to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkPreferenceContainer.vue
    • Adds a new component, MkPreferenceContainer, for managing preferences.
  • packages/frontend/src/components/MkReactionsViewer.reaction.vue
    • Updates MkReactionsViewer.reaction to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/MkReactionsViewer.vue
    • Updates MkReactionsViewer to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkRetentionHeatmap.vue
    • Updates MkRetentionHeatmap to use the new store module for managing application state.
  • packages/frontend/src/components/MkRetentionLineChart.vue
    • Updates MkRetentionLineChart to use the new store module for managing application state.
  • packages/frontend/src/components/MkSuperMenu.vue
    • Updates MkSuperMenu to use the new store module for managing application state.
  • packages/frontend/src/components/MkTimeline.vue
    • Updates MkTimeline to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkToast.vue
    • Updates MkToast to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkUrlPreview.vue
    • Updates MkUrlPreview to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkUserCardMini.vue
    • Updates MkUserCardMini to use the new store module for managing application state.
  • packages/frontend/src/components/MkUserInfo.vue
    • Updates MkUserInfo to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkUserPopup.vue
    • Updates MkUserPopup to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkUserSelectDialog.vue
    • Updates MkUserSelectDialog to use the new store module for managing application state.
  • packages/frontend/src/components/MkUserSetupDialog.vue
    • Updates MkUserSetupDialog to use the new store module for managing application state.
  • packages/frontend/src/components/MkVisitorDashboard.ActiveUsersChart.vue
    • Updates MkVisitorDashboard.ActiveUsersChart to use the new store module for managing application state.
  • packages/frontend/src/components/MkWindow.vue
    • Updates MkWindow to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/MkYouTubePlayer.vue
    • Updates MkYouTubePlayer to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/ShVisibilityColoring.vue
    • Updates ShVisibilityColoring to use the new store module for managing application state.
  • packages/frontend/src/components/global/MkAd.vue
    • Updates MkAd to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/global/MkAvatar.vue
    • Updates MkAvatar to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/global/MkCustomEmoji.vue
    • Updates MkCustomEmoji to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/components/global/MkEmoji.vue
    • Updates MkEmoji to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/global/MkError.vue
    • Updates MkError to use the new prefer module for managing application preferences.
  • packages/frontend/src/components/global/MkFooterSpacer.vue
    • Updates MkFooterSpacer to use the new store module for managing application state.
  • packages/frontend/src/components/global/MkMfm.ts
    • Updates MkMfm to use the new store module for managing application state.
  • packages/frontend/src/components/global/RouterView.vue
    • Updates RouterView to use the new store module for managing application state.
  • packages/frontend/src/deck.ts
    • Updates deck related code to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/directives/autosize.ts
    • Updates autosize directive to use the new store module for managing application state.
  • packages/frontend/src/directives/click-anime.ts
    • Updates click-anime directive to use the new prefer module for managing application preferences.
  • packages/frontend/src/directives/ripple.ts
    • Updates ripple directive to use the new prefer module for managing application preferences.
  • packages/frontend/src/os.ts
    • Updates os to use the new store module for managing application state.
  • packages/frontend/src/pages/settings/accessibility.vue
    • Updates settings/accessibility to use the new prefer module for managing application preferences.
  • packages/frontend/src/pages/settings/appearance.vue
    • Updates settings/appearance to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/deck.vue
    • Updates settings/deck to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/drive.vue
    • Updates settings/drive to use the new prefer module for managing application preferences.
  • packages/frontend/src/pages/settings/emoji-picker.vue
    • Updates settings/emoji-picker to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/general.vue
    • Updates settings/general to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/import-export.vue
    • Updates settings/import-export to use the new store module for managing application state.
  • packages/frontend/src/pages/settings/mute-block.vue
    • Updates settings/mute-block to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/navbar.vue
    • Updates settings/navbar to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/other.vue
    • Updates settings/other to use the new store module for managing application state.
  • packages/frontend/src/pages/settings/plugin.install.vue
    • Updates settings/plugin.install to use the new store module for managing application state.
  • packages/frontend/src/pages/settings/plugin.vue
    • Updates settings/plugin to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/preferences.vue
    • Updates settings/preferences to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/ruru-settings.vue
    • Updates settings/ruru-settings to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/pages/settings/sounds.vue
    • Updates settings/sounds to use the new prefer module for managing application preferences.
  • packages/frontend/src/pages/tag.vue
    • Updates tag to use the new store module for managing application state.
  • packages/frontend/src/pizzax.ts
    • Updates pizzax to use the new store module for managing application state.
  • packages/frontend/src/plugin.ts
    • Updates plugin related code to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/preferences.ts
    • Adds new preferences related code to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/preferences/def.ts
    • Adds new preferences definitions.
  • packages/frontend/src/preferences/profile.ts
    • Adds new preferences profile related code.
  • packages/frontend/src/preferences/store.ts
    • Adds new preferences store related code.
  • packages/frontend/src/scripts/code-highlighter.ts
    • Updates code-highlighter to use the new store module for managing application state.
  • packages/frontend/src/scripts/get-drive-file-menu.ts
    • Updates get-drive-file-menu to use the new prefer module for managing application preferences.
  • packages/frontend/src/scripts/get-note-menu.ts
    • Updates get-note-menu to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/scripts/init-chart.ts
    • Updates init-chart to use the new store module for managing application state.
  • packages/frontend/src/scripts/select-file.ts
    • Updates select-file to use the new prefer module for managing application preferences.
  • packages/frontend/src/scripts/sound.ts
    • Updates sound related code to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/scripts/theme.ts
    • Updates theme related code to use the new prefer module for managing application preferences.
  • packages/frontend/src/ui/common/common.vue
    • Updates ui/common/common to use the new store module for managing application state.
  • packages/frontend/src/ui/common/navbar-for-mobile.vue
    • Updates ui/common/navbar-for-mobile to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/common/navbar.vue
    • Updates ui/common/navbar to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/common/statusbars.vue
    • Updates ui/common/statusbars to use the new prefer module for managing application preferences.
  • packages/frontend/src/ui/common/stream-indicator.vue
    • Updates ui/common/stream-indicator to use the new prefer module for managing application preferences.
  • packages/frontend/src/ui/classic.header.vue
    • Updates ui/classic.header to use the new store module for managing application state.
  • packages/frontend/src/ui/classic.sidebar.vue
    • Updates ui/classic.sidebar to use the new store module for managing application state.
  • packages/frontend/src/ui/classic.vue
    • Updates ui/classic to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck.vue
    • Updates ui/deck to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/antenna-column.vue
    • Updates ui/deck/antenna-column to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/channel-column.vue
    • Updates ui/deck/channel-column to use the new store module for managing application state.
  • packages/frontend/src/ui/deck/column.vue
    • Updates ui/deck/column to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/direct-column.vue
    • Updates ui/deck/direct-column to use the new store module for managing application state.
  • packages/frontend/src/ui/deck/list-column.vue
    • Updates ui/deck/list-column to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/main-column.vue
    • Updates ui/deck/main-column to use the new prefer module for managing application preferences.
  • packages/frontend/src/ui/deck/mentions-column.vue
    • Updates ui/deck/mentions-column to use the new store module for managing application state.
  • packages/frontend/src/ui/deck/role-timeline-column.vue
    • Updates ui/deck/role-timeline-column to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/tl-column.vue
    • Updates ui/deck/tl-column to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/deck/widgets-column.vue
    • Updates ui/deck/widgets-column to use the new store module for managing application state.
  • packages/frontend/src/ui/note.vue
    • Updates ui/note to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/universal.vue
    • Updates ui/universal to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/ui/universal.widgets.vue
    • Updates ui/universal.widgets to use the new store module for managing application state.
  • packages/frontend/src/widgets/WidgetFederation.vue
    • Updates widgets/WidgetFederation to use the new store module for managing application state.
  • packages/frontend/src/widgets/WidgetJobQueue.vue
    • Updates widgets/WidgetJobQueue to use the new store and prefer modules for managing application state and preferences.
  • packages/frontend/src/widgets/WidgetMemo.vue
    • Updates widgets/WidgetMemo to use the new store module for managing application state.
  • packages/frontend/src/widgets/WidgetPhotos.vue
    • Updates widgets/WidgetPhotos to use the new prefer module for managing application preferences.
  • packages/frontend/src/widgets/WidgetTrends.vue
    • Updates widgets/WidgetTrends to use the new store module for managing application state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request appears to be an update to the Misskey project, version 2025.3.2-ruru-1.3.1. Since there are no code changes provided in the patch, I am unable to provide specific feedback on the code itself. However, I can offer some general advice on pull request practices.

Merge Readiness

Since there are no code changes provided, I cannot assess the readiness of this pull request for merging. Please ensure that the pull request includes the necessary code changes for review. I am unable to approve the pull request in any circumstance, and that users should have others review and approve this code before merging.

@Ruruke Ruruke merged commit f6f04a1 into ruru Mar 10, 2025
10 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants