Update bundled SDL2 to 2.0.14

[joao-conde]

@Cobrand opening this for discussion referring to issue #1077 .

I changed what seemed like the relevant code but HAVE NOT TESTED anything because I am unaware of the correct testing procedure. Can you please give me some pointers? Also, feel like this could be added to the README.

[joao-conde]

vcpkg CI is failing so might be the cause for the failures related with the Windows version

[joao-conde]

Tested in my project using my fork as a dependency and everything worked, no more bottleneck as discussed in the issue.

[Cobrand]

Weird that vcpkg fails, you didn't change anything that was related to it...

I can see you have changed the folder 2.0.12 into 2.0.14 and renamed the appropriate variable in build.rs. But the diff shows that every file has been renamed without changes: did you just rename the folder, or was the new folder exactly the same as the old one?

[joao-conde]

I just renamed the folder, thought it was the appropriate way. Is it not?

Its falling only for windows-latest upon building cargo-vcpkg I think

[Cobrand]

You are supposed to take the content of this folder https://github.com/libsdl-org/SDL/tree/main/include instead. I think you'll be able to find it in this snapshot of 2.0.14 https://www.libsdl.org/release/SDL2-2.0.14.zip

[joao-conde]

@Cobrand I feel a bit dumb 😅 I have now copied everything from the SDL release. Literally all files under include/. Even some .cmake ones. Is this the correct procedure?

[Taowyoo]

@joao-conde
@Cobrand
When trying bundled feature. I found this poll request.
I add some log steps in github actions to get more detailed log.
Here is the link of log:
https://github.com/Taowyoo/rust-sdl2/runs/2235510132?check_suite_focus=true#step:5:145
From the log, it seems like a MSVC related problem :

D:\a\rust-sdl2\rust-sdl2\target\vcpkg\buildtrees\sdl2-gfx\src\1.0.4-86ce4cf464\SDL2_gfxPrimitives.c(1766): error C2169: 'lrint': intrinsic function, cannot be defined

According to Microsoft Doc and A post from audacityteam forum:
The lrint is implemented begin from Visual Studio 2019 version 16.9.0.
The windows-latest env is now using Visual Studio Enterprise 2019 | 16.9.31105.61.

[joao-conde]

I've been using my fork on windows as a project dependency and its works fine, I don't know how the CI windows build fails.

[Taowyoo]

I've been using my fork on windows as a project dependency and its works fine, I don't know how the CI windows build fails.

I test CI under windows-2019(which actually is windows-latest) and windows-2016.
https://github.com/Taowyoo/rust-sdl2/actions/runs/705986835
So, it can be confirmed that this is problem from latest update of MSVC 2019

[Cobrand]

Closed by #1086