-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matchedNodeElementReader and serial mesh support for > 2B entities #380
Conversation
hardcoded for hexahedron
fails in verify
problems with coordinates appear in vtu files
detected by gcc 8.2.1
probably does not compile
… pass. Note the bigger changes were in getting the bump version of MGEN to write in the new (modelDim)*1M+dmg_model_dim approach. Some retooling was necessary since the box model has 0 values for tags of all 4 dimensions so error flags had to move to -1.
As of <testCase, status=failing|fixed> 46:matchedNodeElementReader_p1, fixedUpdate 2/3/2023 fixed with new inputs 8d9b08c Inputs likely incorrect.
46:matchedNodeElementReader_p4, fixedUpdate 2/1/2023 fixed with pumi-meshes @ 8ba7e95 and 472d8de Need to update inputs. Only the serial case was updated. 98:embedded_edges, fixedUpdate 2/1/2023 fixed with 65f661a Cause of failure is not known.
6:bezierMesh, fixedUpdate 2/1/2023 fixed, see commit message, ef72e44 Cause unknown. Could be problem with changes to mds buildBox or integer length to support > 2B ents.
8:bezierRefine, fixedUpdate 2/1/2023 fixed, see commit message, ef72e44 Cause unknown.
9:bezierSubdivision, fixedUpdate 2/1/2023 fixed, see commit message, ef72e44 Cause unknown.
10:bezierValidity, fixedUpdate 2/1/2023 fixed, see commit message, ef72e44 Cause unknown.
28:chef-BL_query-diff, fixedUpdate 2/1/2023 Ken confirmed new outputs are OK. Pushed to The diff of expected and 'new' geombc files fails. Ken is checking the generated phasta files. It could just be a difference caused by the increased int length to support > 2B ents. 31:convertExtrudedRoots_diff_crd, fixedUpdate 2/1/2023 fixed with update to 'crd' file: SCOREC/pumi-meshes@4d1a3df Likely OK. Need to manually check diff. |
not sure why this was commented out
github ci builds were failing on this
fixes ci release build error
mner, convert, and > 2B node mesh support
mner, previously matchedNodeElmReader, was initially designed to take a set of text files of connectivity, coordinates, vertex classification and optionally matching, fathers, and solution. At that time it implicitly assumed that the mesh was a box and called routine to create a
.dmg
box model. That original version of the code was therefore limited to meshes of a topological box. The aforementioned vertex classification used hard coded maps to relate one numbering of the.dmg
box entities to the one created internally. mner also previously handled multi-topology by a monolithic, rectangular connectivity with repetition of the last element node for elements having less nodes than the maximum present.convert, previously converted a Simmetrix
.sms
mesh to a.smb
MDS formatted mesh.For cases with more than 2B entities mner failed with address overflows.
In addition to addressing the >2B entities, this merge adds several features needed to support extrusions of arbitrary shape (Simmetrix->convert->MGEN->mner->chef) while preserving MATLAB-Boxes (MATLAB->MGEN (optionally to support unstructured boxes ->mner->chef)) workflows. We drew the other workflows in because the test cases needed to work with non-rectangular representations of multi-topology connectivities added with emerging CGNS file IO. As mner now handles arbitrary extruded models, the
.dmg
model that mner’s inputs are classified against must be created (e.g., mdlConvert or simTranslate, or other) and is now a required input to mner.To make all this generality work, the vertex classification data that mner reads in was generalized to carry the tag and dimension of the model entity each mesh vertex is classified on e.g.,
modelDim*1000000+dmg_model_tag
. So,.dmg
file (either from mdlConvert or boxModel) ,convert was previously enhanced to extract the coordinates and connectivity of the extrusion root. This allows other mesh extrusion programs to perform the extrusion and prepare inputs for mner. To make that process more general, in this merge, convert exports four extra columns beyond the usual x, y, coordinates in the
.crd
file. The third column is the dimension of the model entity the vertex at that x,y, is classified on (on the root). The fourth column is that root model tag number. The fifth column is the entity (d+1) that extrudes from that root model tag. Finally, the 6th column is the model tag of the entity terminating the extrusion. This information allows new entities created by an external meshing program carrying out the extrusion to be properly classified and written to the classification file that mner requires.@KennethEJansen, @cwsmith