Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented LagrangeQuadratic order 2 #7

Merged
merged 1 commit into from
Aug 10, 2015
Merged

implemented LagrangeQuadratic order 2 #7

merged 1 commit into from
Aug 10, 2015

Conversation

YetAnotherMinion
Copy link
Contributor

The doxygen indicates that getLagrange for dimensions 1 and 2 are implemented, while in fact dimension 2 is not.

Get the Lagrangian shape function of some polynomial order.
we have only first and second order so far

I think I got the shape functions right, but please check. My motivation is to get apf::Mesh::changeShape(apf::getLagrange(2)) to work and automatically create the 9 nodes. I do see where the new nodes get added to the mesh, so if you can point that file out I can also address that too. I could not find the ordering of the nodes in eta space, so I went with ordering in Hughes. If the shape functions and gradients are correct, then it should be trivial to reorder them by someone who does know the ordering.

@YetAnotherMinion
Copy link
Contributor Author

Also it makes the shape functions much easier to read when you substitute a single symbol for xi[0], xi[1] ,... It will get optimized out by compiler anyway and makes the tight grouping style of arithmetic operators favored by this code base a little easier to understand. If the shape functions look good one can always do a local find and replace to put those xi[i]'s back if that is the convention

@ibaned
Copy link
Contributor

ibaned commented Aug 10, 2015

yea, theres a whole funny story about the serendipity quad but the short version is I was lazy and you seem to have wrapped it up nicely so I'll pull this and run a couple sanity tests.

Thanks !

by the way, the nodes will take care of themselves, that countNodes function controls it all.
also, the single-char names are fine, but its dangerous to go back and change the existing
code so I'll just take this new stuff as is.

ibaned added a commit that referenced this pull request Aug 10, 2015
implemented LagrangeQuadratic order 2
@ibaned ibaned merged commit ddeea4f into SCOREC:master Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants