blackrogue dungeoninfo fix

[KaraxSro]

When using BlackRogue Cap 100 client the dungeoninfo only has id and dungeonpath, no service.
This causes an exception on loading, and the Player object will be null, and it will cause infinite null reference exceptions

[SDClowen]

Hi. First of all, thank you for helping RSBot.

I can't merge your code because it breaks compatibility with other games. However, I can give you a few suggestions. Just add an optional for service in the regex string and you'll have solved the problem!

Also, remove the var data = line.Split('\t'); line, I think it's not in use.

You can use the code directly if you want. Don't forget to test it before committing.

var service = 1;
var isNewer = line.StartsWith("0\t") || line.StartsWith("1\t");

// Optional service regex
var match = Regex.Match(line, @"^(?:(?<service>0|1)\t)?(?<id>\d+)\t(?<path>.+)$");

if (isNewer && !int.TryParse(match.Groups["service"].Value, out service))
    throw new Exception($"Failed to load dungeon info: malformed service on {line}");

[KaraxSro]

Hi! Could you take a closer look? I'm pretty confident it will not break anything. It previously worked with VSRO274, only had problems with BlackRogue100. After the fix it worked on both of them. I also tested the function with JSRO, ZSZC and VSRO188

I only found these 2 structures,

ZSZC, BlackRogue, JSRO

Checking if the line starts with 0 or 1 will incorrectly assume this is a newer file on the first dungeon

// ¸®Á¯ID	ÆÄÀÏÀ̸§
1	"Dungeon\wchina\Dunhwang_Cv.dof"
2	"Dungeon\china\jinsi_floor06.dof"
3	"Dungeon\china\jinsi_floor05.dof"
4	"Dungeon\china\jinsi_floor04.dof"
5	"Dungeon\china\jinsi_floor03.dof"
6	"Dungeon\china\jinsi_floor02.dof"
7	"Dungeon\china\jinsi_floor01.dof"
9	"Dungeon\wchina\event.dof"

And this is VSRO188, VSRO274

//¼­ºñ½º	//¸®Á¯ID	ÆÄÀÏÀ̸§
1	1	"Dungeon\wchina\Dunhwang_Cv.dof"
1	2	"Dungeon\china\jinsi_floor06.dof"
1	3	"Dungeon\china\jinsi_floor05.dof"
1	4	"Dungeon\china\jinsi_floor04.dof"
1	5	"Dungeon\china\jinsi_floor03.dof"
1	6	"Dungeon\china\jinsi_floor02.dof"
1	7	"Dungeon\china\jinsi_floor01.dof"
0	8	"Dungeon\wchina\gngwc.dof"
1	9	"Dungeon\wchina\event.dof"
1	10	"Dungeon\Asiam\R1_Cv\pha_cv_selkis.dof"
1	11	"Dungeon\Asiam\R1_Cv\pha_cv_neith.dof"
1	12	"Dungeon\Asiam\R1_Cv\pha_cv_anubis.dof"
1	13	"Dungeon\Asiam\R1_Cv\pha_cv_isis.dof"
1	14	"Dungeon\Asiam\R1_Cv\pha_cv_haro.dof"
1	15	"Dungeon\Asiam\R2_Cv\st_seth.dof"
1	16	"Dungeon\Asiam\R1_Cv\pha_cv.dof"
1	17	"Dungeon\wchina\fortress_dungeon.dof"
1	18	"Dungeon\Property\flame\flame.dof"
0	19	"Dungeon\Jupiter\Piety\piety_boss_di.dof"
0	20	"Dungeon\Jupiter\Piety\piety_boss_uno.dof"
0	21	"Dungeon\Jupiter\Piety\piety_boss_upi.dof"
0	22	"Dungeon\Jupiter\Hide\hide.dof"
0	23	"Dungeon\etc\gm_event.dof"
0	24	"Dungeon\etc\prison.dof"

What I do is I split the line and put them on a stack.
On the top of stack will be the dungeonpath.
I pop it, remove the quotes using the regex, that will be the dungeonpath.
Then pop again and convert it to the dungeonId.
If there is still something on the stack, that means it is a newer file. so I pop it and check if service is 0 or 1.
If service is 0 I won't load it, if 1 I do

So I could use it previously on VSRO274, but not on BlackRogue. After the fix it works for both of them, could log in and start the bot normally.

Could you tell me if I missed anything and it still breaks some files?

Thanks in advance!

[SDClowen]

Yes, you are right. However, the order and understandability of the code is also very important for us, rather than the code working. As a solution, instead of checking the service, we can check the number of split tabs.

Example code:

var service = 1;
var match = Regex.Match(line, @"^(?:(?<service>0|1)\t)?(?<id>\d+)\t(?<path>.+)$");

if (!match.Success)
    throw new Exception($"Failed to load dungeon info: invalid format on {line}");

bool hasServiceField = line.Split('\t').Length >= 3;

if (hasServiceField && !int.TryParse(match.Groups["service"].Value, out service))
    throw new Exception($"Failed to load dungeon info: malformed service on {line}");

    

[KaraxSro]

I modified it to use regex, no need to check the length, since the service match is optional, we can check if it matched or not, and not throw an exception. Tested, working.

[SDClowen]

Merged.