changed min cmake ver and CMAKE_SOURCE_DIR to PROJECT_SOURCE_DIR #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
requested changes
Mar 16, 2022
|
Can you change the following line Line 38 in 317f58f to something like this? Not sure if it's the newer CMake version, but seems like it fails to detect AppleClang on macOS now. Additionally, could you squash the commits into one? |
|
I'm sorry, I'm not that experienced with git, I think the squashing didn't go well but I made the requested changes |
brightprogrammer
force-pushed
the
buildfix
branch
from
81e999f to
48145fb
Compare
ok squashing worked, can you please check now? 😄 |
|
is it possibble that the problem is in the machine on which builds are running on? |
Change minimum CMake version
eXpl0it3r
approved these changes
Mar 17, 2022
|
I managed to get it working, by using the code from SFML's 2.6.x branch 😄 |
|
Thanks a lot for this fix! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a build error when building CSFML stating that it failed to find files in
cmakefolder. Also there were some warnings for cmake version so changed cmake version too. This fixed the build for me.