Reduce duplicated Linux and macOS libraries in NuGet Package #250
+32
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
force-pushed
the
feature/reduce-duplicates-nuget
branch
from
d907a0e to
6d72b91
Compare
eXpl0it3r
force-pushed
the
feature/reduce-duplicates-nuget
branch
6 times, most recently
from
cfe3216 to
864397c
Compare
ChrisThrasher
approved these changes
May 18, 2024
eXpl0it3r
force-pushed
the
feature/reduce-duplicates-nuget
branch
3 times, most recently
from
04715c2 to
bf6154c
Compare
eXpl0it3r
force-pushed
the
feature/reduce-duplicates-nuget
branch
from
bf6154c to
4fe327b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As NuGet doesn't support symlinks (NuGet/Home#10734), we either have to ship all the libraries in three different versions, or ensure that we're only ever using the one version everywhere.
To reduce duplication and unnecessary size, we'll only use the
(c)sfml-*.so.2.6or(c)sfml-*.2.6.dylibrespectively. See also SFML/SFML.Net#247Also fixes the issues reported by @kimci86 in #249