-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display bulk actions associated with rights that the users do not have #12015
Comments
…tureEnabled() and UserProvider.getCurrent().hasUserRight() occurrences with methods from UiUtil.java
…y_actions_associated_with_rights_that_the_users_do_not_have #12015 - Do not display bulk actions if the necessary rigths are missing
Tested on local env version 1.95.1 |
I'm reopening this ticket because I've found a bug related to a requirement from 2). It was not specified (therefore implemented) that in case of Samples, the problem appears for Human Samples for bulk actions: delete/restore (requires SAMPLE_DELETE right) and for Environment Samples (requires ENVIRONMENT_SAMPLE_DELETE). For Human Samples the problem was fixed but for Environment Samples is still present ( Delete appears in bulk actions when the user does not have delete environment samples right). |
…ing ENVIRONMENT_SAMPLE_DELETE right
…y rigths are missing
…ionFacade().isFeatureEnabled() and UserProvider.getCurrent().hasUserRight() occurrences with methods from UiUtil.java
…rticipantsView and HumanSampleGridComponent
…y_delete_bulk_action_without_delete_environment_samples_right #12015 - Delete should not appear in bulk actions if the user is miss…
Problem Description
Currently, the expected behavior in regards to the display of the bulk actions associated with rights that the logged in users do not have is met only for the 'Messages' directory - bulk action 'Delete', 'Upload quarantine documents' in each directory, and the 'Delete/restore', 'Archive/De-archive' in the 'Events' directory and 'Event participants' tabs where if the respective rights are missing the associated actions are not displayed in the 'Bulk actions' dropdowns.
There are 2 perspectives that need to be addressed:
- Cases directory - edit bulk actions:
If the user has UserRight.CASE_EDIT the bulk actions dropdown will contain the "Edit" functionality but the actions inside the bulk edit popup should be limited based on the specific case edit rights ( same logic as there is is place when editing a case in single mode). When the user does not have a specific edit right, the checkbox should be read only.
The following rights are necessary for the specific edit actions from "Edit cases" popup window:
Note: There is no need to set the following checkboxes to readOnly based on rights:
Proposed Change
The bulk actions displayed for the user should all be consistently displayed based on the rights of the user logged in, as we currently do for part of the delete/restore, archive/de-archive, and upload documents actions that are not displayed in some bulk actions dropdowns when the respective rights are missing.
Added Value/Benefit
Consistency in regards to the display based on the user's rights and the display of less error messages caused by displaying actions associated with missing rights.
Acceptance Criteria
Directories to be covered:
Implementation Details
No response
Mockups
No response
Additional Information
An extensive explanation on which actions are dependent on which rights was written and can be provided to help with the development of the issue.
The display of the bulk edit mode across directories where it is implemented will be addressed by #11881
The text was updated successfully, but these errors were encountered: