Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12841 Add validation to the national health ID field #12897

Merged
merged 2 commits into from
Jan 25, 2024
Merged

#12841 Add validation to the national health ID field #12897

merged 2 commits into from
Jan 25, 2024

Conversation

leventegal-she
Copy link
Contributor

Fixes #12841

@sormas-vitagroup
Copy link
Contributor

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12897

MateStrysewske
MateStrysewske suggested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

National health ID does not seem properly validated against the birth date if it exists; if no birth date is entered, validation seems correct

@sormas-vitagroup
Copy link
Contributor

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12897

@leventegal-she leventegal-she merged commit a4cb6d6 into development Jan 25, 2024
7 of 12 checks passed
@leventegal-she leventegal-she deleted the feature-12841-Add-validation-to-the-national-health-ID-field branch January 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateStrysewske MateStrysewske MateStrysewske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation to the national health ID field [0.5]
3 participants
@leventegal-she @sormas-vitagroup @MateStrysewske