Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] 6.2 Health Checks - cAdvisor??? #858

Closed
Martin-Weiss opened this issue Jun 3, 2020 · 2 comments
Closed

[doc] 6.2 Health Checks - cAdvisor??? #858

Martin-Weiss opened this issue Jun 3, 2020 · 2 comments
Assignees
@r0ckarong
Labels
Backport Change needs to be backported to a previous version indicated with label Blocked Blocked by lack of information or external factors EngineeringInput NeedsEngineering Input v4 CaaSP v4 v5 Future Release with Rancher
Milestone
Sprint 31

Comments

@Martin-Weiss
Copy link
Contributor

6.2 Health Checks:

https://susedoc.github.io/doc-caasp/master/single-html/caasp-admin/#_health_checks

I believe this sentence needs to be removed as we do not have cAdvisor reachable anymore and we also do not have this on the admin node:

A very basic (visual) health check can be achieved by accessing cAdvisor on the admin node at port 4194. This will display a basic statistics UI about the cluster resources.
@r0ckarong
Copy link
Contributor

@lcavajani Is this fully deprecated now? Can I remove this sentence? We still have prometheus checks against cAdvisor.

@r0ckarong r0ckarong self-assigned this Jun 3, 2020
@r0ckarong r0ckarong added this to the Sprint 31 milestone Jun 3, 2020
@r0ckarong r0ckarong added Backport Change needs to be backported to a previous version indicated with label Blocked Blocked by lack of information or external factors EngineeringInput NeedsEngineering Input Reported v4 CaaSP v4 v5 Future Release with Rancher labels Jun 3, 2020
@spiarh
Copy link
Contributor

spiarh commented Jun 3, 2020

@r0ckarong yes cAdvisor is fully deprecated, Prometheus is using kubelet api to fetch metrics

r0ckarong pushed a commit that referenced this issue Jun 5, 2020
Remove mentions of obsolete cadvisor endpoints (Closes #858)
b44576f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0ckarong r0ckarong

Labels
Backport Change needs to be backported to a previous version indicated with label Blocked Blocked by lack of information or external factors EngineeringInput NeedsEngineering Input v4 CaaSP v4 v5 Future Release with Rancher
Projects
None yet
Milestone
Sprint 31
Development

No branches or pull requests
3 participants
@r0ckarong @Martin-Weiss @spiarh