Fix Dex configuration is broken after update (#1014)

[cclhsu]

Describe your changes

1. Instead of modify Dex connector using addon after deploy, edit configmap directly.

[thehejik]

LGTM, thanks

[r0ckarong]

Looks fine, some small phrases need to be corrected.

[jenting]

I don't think we need to restart gangway pods since this is for fix dex configuration.

[jenting]

@cclhsu Sorry I don't know the discussion history, but is it better to ask the customer to download the existing oidc-dex-config ConfigMap before addon upgrade, then re-apply the downloaded oidc-dex-config ConfigMap after addon upgraded. Since as I know, we did not change the oidc-dex-config ConfigMap since skuba 4.0.0.

kubectl get configmap oidc-dex-config -n kube-system -o yaml > oidc-dex-config.yaml
kubectl replace -f oidc-dex-config.yaml

[nkoranova]

@jordimassaguerpla is this relevant for 4.0.2?

[davidcassany]

@jordimassaguerpla is this relevant for 4.0.2?

Yes it is, this makes reference to SUSE/avant-garde#1014

[nkoranova]

@cclhsu Sorry I don't know the discussion history, but is it better to ask the customer to download the existing oidc-dex-config ConfigMap before addon upgrade, then re-apply the downloaded oidc-dex-config ConfigMap after addon upgraded. Since as I know, we did not change the oidc-dex-config ConfigMap since skuba 4.0.0.

kubectl get configmap oidc-dex-config -n kube-system -o yaml > oidc-dex-config.yaml
kubectl replace -f oidc-dex-config.yaml

I asked Clark about this in a private message and apparently both ways are OK, it seems to be a matter of preference. So merging now. Thanks for the contribution!

[r0ckarong]

@nkoranova Can you merge this to master as well please?