Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of users and OIDC token refresh (Closes #753) #784

Merged
merged 1 commit into from
May 5, 2020

Conversation

r0ckarong
Copy link
Contributor

@innobead Please review the wording. I'm not sure I understood the error cases 100%. Please just amend commits or changes to this PR.

@r0ckarong r0ckarong added Enhancement Fix is an enhancement v4 CaaSP v4 AdminGuide Fix will change the Admin Guide APJ squad labels Apr 29, 2020
@r0ckarong r0ckarong added this to the Sprint 28 milestone Apr 29, 2020
@r0ckarong r0ckarong self-assigned this Apr 29, 2020
@r0ckarong r0ckarong requested a review from innobead April 29, 2020 13:32
@r0ckarong r0ckarong linked an issue Apr 29, 2020 that may be closed by this pull request
@r0ckarong r0ckarong added the On-Hold PR needs work and should not be merged even if reviews are complete label Apr 30, 2020
@r0ckarong r0ckarong modified the milestones: Sprint 28, Sprint 29 May 4, 2020
Copy link

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r0ckarong r0ckarong merged commit 7b195af into master May 5, 2020
@r0ckarong r0ckarong deleted the clarifiy-token-refresh branch May 5, 2020 09:40
@cclhsu cclhsu added the v5 Future Release with Rancher label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AdminGuide Fix will change the Admin Guide APJ squad Enhancement Fix is an enhancement On-Hold PR needs work and should not be merged even if reviews are complete v4 CaaSP v4 v5 Future Release with Rancher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] 4.5.3.2.1.3 OIDC Tokens
4 participants