Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance terraform vsphere_resource_pool details #797

Merged

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented May 11, 2020

Make sure it's tested

N/A

Describe your changes

Sync vsphere_resource_pool example with with terraform site, xref: https://www.terraform.io/docs/providers/vsphere/d/resource_pool.html.
Add reference link to vsphere resource pool details

Related Issues / Projects

Relates to: #794

Enable maintainer updates

Please enable maintainer updates so we can push commits into your branch to make collaboration and reviews easier.

Do not force push your branch

Please avoid force pushing to branches that are subject of pull requests. Force pushing breaks maintainer commits in many cases and is very hard (if not impossible) to untangle for backporting.

Labels

Please set any (and all) appropriate labels that describe the status of the PR.

Label Description
P1 PR should be worked on and merged as soon as possible
Blocked Work can not proceed because other work has not been completed, PR can not be merged (code has not been merged but documentation is ready)
On-Hold Underlying work is completed but the PR should not be merged
ReleaseNotes User interaction is required after the introduction of this change and the change must be mentioned in the release notes
v3/v4/v4.x Which version of the release the PR should be merged into, this can be multiple versions, please set the "Backport" label if it needs to go into a previous release
Needs Review Some details of the PR are known to be incomplete and must be discussed with other engineers before merging (if possible assign reviewers or cc mention in comments), PR can not be merged

Signed-off-by: Chin-Ya Huang chin-ya.huang@suse.com

@c3y1huang c3y1huang self-assigned this May 11, 2020
@c3y1huang c3y1huang added the Enhancement Fix is an enhancement label May 11, 2020
@c3y1huang c3y1huang force-pushed the c3y1/enhance/vsphere-resource-pool branch 2 times, most recently from 457735e to b577ea9 Compare May 11, 2020 09:04
@r0ckarong r0ckarong added this to the Sprint 29 milestone May 11, 2020
@r0ckarong r0ckarong self-assigned this May 11, 2020
@r0ckarong r0ckarong added 4.2.1 DeploymentGuide Fix will change the Deployment Guide APJ squad labels May 11, 2020
Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c3y1huang thanks

@r0ckarong
Copy link
Contributor

@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged.

@jordimassaguerpla
Copy link
Member

@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged.

When QA give us the ok from Staging 4.2.1.

@jordimassaguerpla
Copy link
Member

@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged.

When QA give us the ok from Staging 4.2.1.

Meaning Martin or Tomas .... but Staging 4.2.1 is not yet passing the precheck tests, so they cannot give you the 👍 yet

@r0ckarong
Copy link
Contributor

@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged.

When QA give us the ok from Staging 4.2.1.

Meaning Martin or Tomas .... but Staging 4.2.1 is not yet passing the precheck tests, so they cannot give you the +1 yet

I meant tell me when we have the thumbs up :)

@jordimassaguerpla
Copy link
Member

@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged.

When QA give us the ok from Staging 4.2.1.

Meaning Martin or Tomas .... but Staging 4.2.1 is not yet passing the precheck tests, so they cannot give you the +1 yet

I meant tell me when we have the thumbs up :)

sure :)

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@r0ckarong r0ckarong force-pushed the c3y1/enhance/vsphere-resource-pool branch from b577ea9 to 08bfb5b Compare May 18, 2020 10:23
@r0ckarong r0ckarong modified the milestones: Sprint 29, Sprint 30 May 19, 2020
@r0ckarong r0ckarong changed the base branch from master to maintenance/CaaS4 May 20, 2020 12:28
@nkoranova nkoranova merged commit f29d81d into SUSE:maintenance/CaaS4 May 25, 2020
r0ckarong pushed a commit that referenced this pull request Jun 3, 2020
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
r0ckarong pushed a commit that referenced this pull request Jun 3, 2020
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APJ squad DeploymentGuide Fix will change the Deployment Guide Enhancement Fix is an enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] 3.3.5.1 Using Terraform - resource pool definition needs to have better explanation / example
6 participants