-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance terraform vsphere_resource_pool details #797
Enhance terraform vsphere_resource_pool details #797
Conversation
457735e
to
b577ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c3y1huang thanks
@jordimassaguerpla The vSphere topic now just needs your OK after QA. Please let me know when this can be merged. |
When QA give us the ok from Staging 4.2.1. |
Meaning Martin or Tomas .... but Staging 4.2.1 is not yet passing the precheck tests, so they cannot give you the 👍 yet |
I meant tell me when we have the thumbs up :) |
sure :) |
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
b577ea9
to
08bfb5b
Compare
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Make sure it's tested
N/A
Describe your changes
Sync vsphere_resource_pool example with with terraform site, xref: https://www.terraform.io/docs/providers/vsphere/d/resource_pool.html.
Add reference link to vsphere resource pool details
Related Issues / Projects
Relates to: #794
Enable maintainer updates
Please enable maintainer updates so we can push commits into your branch to make collaboration and reviews easier.
Do not force push your branch
Please avoid force pushing to branches that are subject of pull requests. Force pushing breaks maintainer commits in many cases and is very hard (if not impossible) to untangle for backporting.
Labels
Please set any (and all) appropriate labels that describe the status of the PR.
Signed-off-by: Chin-Ya Huang chin-ya.huang@suse.com