Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix suggestion for vspshere configuration (#1618) #856

Merged
merged 1 commit into from
May 29, 2020

Conversation

cclhsu
Copy link
Contributor

@cclhsu cclhsu commented May 29, 2020

fix suggestion for vspshere configuration (#1618)

Signed-off-by: cclhsu clark.hsu@suse.com

Make sure it's tested

Technical writers will not always be able to verify the implementation!

Any PR opened is assumed to have been verified by QA if not designated by comments or labels otherwise. Please make sure you have tested the changes and included any information that a user would require to use the documentation.

Describe your changes

Add double quotation for <VC_IP_OR_FQDN>

Related Issues / Projects

Please provide links to Bugzilla and other GitHub projects with your description if they are related to the changes.

Relates to: https://github.com/SUSE/avant-garde/issues/1618

Enable maintainer updates

Please enable maintainer updates so we can push commits into your branch to make collaboration and reviews easier.

Do not force push your branch

Please avoid force pushing to branches that are subject of pull requests. Force pushing breaks maintainer commits in many cases and is very hard (if not impossible) to untangle for backporting.

Labels

Please set any (and all) appropriate labels that describe the status of the PR.

Label Description
P1 PR should be worked on and merged as soon as possible
Blocked Work can not proceed because other work has not been completed, PR can not be merged (code has not been merged but documentation is ready)
On-Hold Underlying work is completed but the PR should not be merged
ReleaseNotes User interaction is required after the introduction of this change and the change must be mentioned in the release notes
v3/v4/v4.x Which version of the release the PR should be merged into, this can be multiple versions, please set the "Backport" label if it needs to go into a previous release
Needs Review Some details of the PR are known to be incomplete and must be discussed with other engineers before merging (if possible assign reviewers or cc mention in comments), PR can not be merged

fix suggestion for vspshere configuration (#1618)

Signed-off-by: cclhsu <clark.hsu@suse.com>
@jenting jenting merged commit 2092921 into SUSE:maintenance/CaaS4 May 29, 2020
@cclhsu cclhsu deleted the vspshere_configuration_1618 branch June 15, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants