Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure cloud provider support document #878

Merged

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Jun 11, 2020

Describe your changes

The skuba added support for in-tree Azure Cloud Provider.

Related Issues / Projects

Relates to:

Signed-off-by: Chin-Ya Huang chin-ya.huang@suse.com

@c3y1huang c3y1huang added On-Hold PR needs work and should not be merged even if reviews are complete Blocked Blocked by lack of information or external factors AdminGuide Fix will change the Admin Guide DeploymentGuide Fix will change the Deployment Guide labels Jun 11, 2020
@c3y1huang c3y1huang self-assigned this Jun 11, 2020
Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments to resolve.

@c3y1huang
Copy link
Contributor Author

c3y1huang commented Jun 23, 2020

This will wait until add documents for azure terraform gets merged to update parts relates to cluster provision.

cc/ @r0ckarong @nkoranova

@innobead innobead added the v5 Future Release with Rancher label Jun 29, 2020
@innobead
Copy link
Contributor

cc @cclhsu

@jordimassaguerpla jordimassaguerpla added 4.5.x To be released during 4.5.x lifetime. Not a release blocker for 4.5.0 and removed v5 Future Release with Rancher labels Aug 5, 2020
@c3y1huang c3y1huang force-pushed the c3y1/feature/azure-in-tree-cloud-provider branch from abb84ee to 009a956 Compare August 6, 2020 01:31
@c3y1huang
Copy link
Contributor Author

rebased.

@c3y1huang c3y1huang force-pushed the c3y1/feature/azure-in-tree-cloud-provider branch from 009a956 to 85c5709 Compare September 8, 2020 10:05
@c3y1huang
Copy link
Contributor Author

rebased and fixed IDREF.

@r0ckarong r0ckarong added the ReleaseNotes Fix has impact that needs to be mentioned in the release notes label Oct 14, 2020
@r0ckarong
Copy link
Contributor

@c3y1huang Added a commit with some minor integration, please rebase before pushing again.

@r0ckarong r0ckarong added 4.5.2 and removed 4.5.x To be released during 4.5.x lifetime. Not a release blocker for 4.5.0 Blocked Blocked by lack of information or external factors labels Nov 9, 2020
@r0ckarong
Copy link
Contributor

@c3y1huang Did anything change since the last update for this feature? Please have another review so I can merge this for the 4.5.2 release. Thank you!

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang and others added 4 commits November 11, 2020 17:24
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the c3y1/feature/azure-in-tree-cloud-provider branch from 34aa669 to 278ac60 Compare November 11, 2020 09:24
@c3y1huang c3y1huang marked this pull request as ready for review November 11, 2020 09:24
@c3y1huang
Copy link
Contributor Author

c3y1huang commented Nov 11, 2020

@c3y1huang Did anything change since the last update for this feature? Please have another review so I can merge this for the 4.5.2 release. Thank you!

Nothing had changed since the last update. This one is ready for review and is just waiting for #878 (comment) which can also be later updated.

@c3y1huang
Copy link
Contributor Author

rebased.

@r0ckarong r0ckarong merged commit 1aff9e9 into SUSE:master Nov 11, 2020
@c3y1huang c3y1huang deleted the c3y1/feature/azure-in-tree-cloud-provider branch November 12, 2020 00:44
r0ckarong pushed a commit that referenced this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5.2 AdminGuide Fix will change the Admin Guide DeploymentGuide Fix will change the Deployment Guide On-Hold PR needs work and should not be merged even if reviews are complete ReleaseNotes Fix has impact that needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants