Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance skuba addon upgrade plan #923

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Enhance skuba addon upgrade plan #923

merged 3 commits into from
Jul 23, 2020

Conversation

jenting
Copy link

@jenting jenting commented Jul 10, 2020 •
edited
Loading

Describe your changes

The skuba addon upgrade plan also do Kubernetes server-side dry-run validation.

Related Issues / Projects

Fixes: https://github.com/SUSE/avant-garde/issues/1765

@jenting jenting added v5 Future Release with Rancher AdminGuide Fix will change the Admin Guide labels Jul 10, 2020
@jenting jenting marked this pull request as draft July 10, 2020 05:59
@jenting jenting added the On-Hold PR needs work and should not be merged even if reviews are complete label Jul 10, 2020
@jenting jenting mentioned this pull request Jul 10, 2020
Merged
innobead
innobead requested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments to resolve.

c3y1huang
c3y1huang reviewed Jul 13, 2020
View reviewed changes
@jenting jenting requested review from innobead and c3y1huang July 13, 2020 05:27
@jenting jenting marked this pull request as ready for review July 13, 2020 05:27
@jenting
Copy link
Author

jenting commented Jul 13, 2020

Some problems in Travis CI 😒

$ wget https://raw.githubusercontent.com/openSUSE/doc-ci/master/travis/travis.sh
--2020-07-13 05:29:42--  https://raw.githubusercontent.com/openSUSE/doc-ci/master/travis/travis.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.0.133, 151.101.64.133, 151.101.128.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.0.133|:443... connected.
HTTP request sent, awaiting response... 500 Internal Server Error
2020-07-13 05:29:42 ERROR 500: Internal Server Error.
The command "wget https://raw.githubusercontent.com/openSUSE/doc-ci/master/travis/travis.sh" failed and exited with 8 during .

@jenting jenting self-assigned this Jul 13, 2020
@jenting
Copy link
Author

jenting commented Jul 14, 2020

Travis CI is happy now 😄

@jenting jenting removed the On-Hold PR needs work and should not be merged even if reviews are complete label Jul 23, 2020
Enhance skuba addon upgrade plan
d916d99 
the `skuba addon upgrade plan` also do Kubernetes server-side
dry-run validation.
@jenting
Copy link
Author

jenting commented Jul 23, 2020

skuba PR merged, It's ready to review~

@r0ckarong r0ckarong merged commit d26beb0 into SUSE:master Jul 23, 2020
@r0ckarong r0ckarong added this to the Sprint 34 milestone Jul 23, 2020
@jenting jenting deleted the enhance-skuba-addon-upgrade-plan branch July 23, 2020 09:17
r0ckarong pushed a commit that referenced this pull request Jul 24, 2020
Revert "Enhance skuba addon upgrade plan (#923)"
7f68d72 
This reverts commit d26beb0.
@r0ckarong r0ckarong mentioned this pull request Jul 24, 2020
Merged
r0ckarong pushed a commit that referenced this pull request Jul 24, 2020
Revert "Enhance skuba addon upgrade plan (#923)" (#937)
277b630 
This reverts commit d26beb0.
@r0ckarong r0ckarong mentioned this pull request Jul 24, 2020
Closed
@jordimassaguerpla
Copy link
Member

Not in 5.0.0

@r0ckarong r0ckarong mentioned this pull request Jul 24, 2020
Merged
r0ckarong pushed a commit that referenced this pull request Jul 24, 2020
Revert "Enhance skuba addon upgrade plan (#923)" (#947)
f43bd5f 
This reverts commit d26beb0.
r0ckarong pushed a commit that referenced this pull request Oct 27, 2020
Revert "Revert "Enhance skuba addon upgrade plan (#923)" (#937)"
2519e1e 
This reverts commit 277b630.
r0ckarong pushed a commit that referenced this pull request Oct 27, 2020
Revert "Revert "Enhance skuba addon upgrade plan (#923)" (#937)"
245f751 
This reverts commit 277b630.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@nkoranova nkoranova Awaiting requested review from nkoranova

@cclhsu cclhsu Awaiting requested review from cclhsu

@r0ckarong r0ckarong Awaiting requested review from r0ckarong

@c3y1huang c3y1huang Awaiting requested review from c3y1huang

Assignees

@jenting jenting

Labels
AdminGuide Fix will change the Admin Guide v5 Future Release with Rancher
Projects
None yet
Milestone
Sprint 34
Development

Successfully merging this pull request may close these issues.
5 participants
@jenting @jordimassaguerpla @innobead @c3y1huang @r0ckarong