Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Individual and Wildcard certificate #933

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Individual and Wildcard certificate #933

merged 2 commits into from
Jul 23, 2020

Conversation

jenting
Copy link

@jenting jenting commented Jul 21, 2020

Describe your changes

Describes what is the individual certificate and the wildcard certificate.

  • For subdomains: add both the individual certificate and the wildcard certificate
  • For subpaths: add the individual certificate since it only has one domain name

Related Issues / Projects

Please provide links to Bugzilla and other GitHub projects with your description if they are related to the changes.

Fixes: #835

@jenting jenting requested review from r0ckarong and nkoranova July 21, 2020 02:34
@jenting jenting self-assigned this Jul 21, 2020
@jenting jenting changed the title Issue 835 Individual and wildcard certificate Jul 21, 2020
@jenting jenting changed the title Individual and wildcard certificate Individual and Wildcard certificate Jul 21, 2020
@jenting jenting added AdminGuide Fix will change the Admin Guide Backport Change needs to be backported to a previous version indicated with label 4.5.0 CaasP v5 release without Rancher v4 CaaSP v4 labels Jul 21, 2020
@jenting jenting requested a review from innobead July 21, 2020 07:46
innobead
innobead approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments to resolve.

@jenting jenting requested a review from c3y1huang July 22, 2020 00:41
@jenting
Copy link
Author

jenting commented Jul 22, 2020

CI is not happy with the un-related change.

@jenting
Copy link
Author

jenting commented Jul 22, 2020

okay, address the format problem to make CI happy.

JenTing Hsiao and others added 2 commits July 23, 2020 00:09
@r0ckarong r0ckarong added this to the Sprint 34 milestone Jul 23, 2020
@r0ckarong r0ckarong self-assigned this Jul 23, 2020
@r0ckarong r0ckarong merged commit 81ee343 into SUSE:master Jul 23, 2020
r0ckarong pushed a commit that referenced this pull request Jul 23, 2020
Add instructions for Individual and Wildcard certificate (#933)
8a7307b 
* Describes individual and wildcard TLS certificate

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>

* Updated wording for certificates explanation

Co-authored-by: Markus Napp <mnapp@suse.com>
@jenting jenting deleted the issue-835 branch July 23, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@c3y1huang c3y1huang c3y1huang approved these changes

@r0ckarong r0ckarong Awaiting requested review from r0ckarong

@nkoranova nkoranova Awaiting requested review from nkoranova

Assignees

@r0ckarong r0ckarong

@jenting jenting

Labels
4.5.0 CaasP v5 release without Rancher AdminGuide Fix will change the Admin Guide Backport Change needs to be backported to a previous version indicated with label v4 CaaSP v4
Projects
None yet
Milestone
Sprint 34
Development

Successfully merging this pull request may close these issues.

[doc] 4.8.1.3 Create DNS entries - add info about wildcard DNS entry
4 participants
@jenting @innobead @c3y1huang @r0ckarong