-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configures subpath by helm chart values #934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, being Integrated in monitoring yaml is better than independent ingress approach.
LGTM.
** **LoadBalancer**: `+https://example.com/alertmanger+` | ||
** **NodePort**: `+https://example.com:32443/alertmanager+` | ||
** **External IPs**: `+https://example.com/alertmanager+` | ||
** **LoadBalancer**: `+https://example.com/alertmanager+` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to fix the spelling mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's make CI happy~ |
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@r0ckarong This is ready to review. |
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Describe your changes
Configures subpath by helm chart values.
Note: only the grafana needs to set up the Nginx rewrite target.
Related Issues / Projects
Please provide links to Bugzilla and other GitHub projects with your description if they are related to the changes.
Fixes: #769