Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configures subpath by helm chart values #934

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Configures subpath by helm chart values #934

merged 1 commit into from
Aug 3, 2020

Conversation

jenting
Copy link

@jenting jenting commented Jul 21, 2020

Describe your changes

Configures subpath by helm chart values.

Note: only the grafana needs to set up the Nginx rewrite target.

Related Issues / Projects

Please provide links to Bugzilla and other GitHub projects with your description if they are related to the changes.

Fixes: #769

@jenting jenting self-assigned this Jul 21, 2020
@jenting jenting requested review from r0ckarong, suseclee and nkoranova and removed request for r0ckarong July 21, 2020 07:44
@jenting jenting added 4.5.0 CaasP v5 release without Rancher Backport Change needs to be backported to a previous version indicated with label v4 CaaSP v4 AdminGuide Fix will change the Admin Guide labels Jul 21, 2020
@jenting jenting requested review from innobead and maximenoel8 July 21, 2020 07:46
Copy link
Contributor

@suseclee suseclee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, being Integrated in monitoring yaml is better than independent ingress approach.
LGTM.

** **LoadBalancer**: `+https://example.com/alertmanger+`
** **NodePort**: `+https://example.com:32443/alertmanager+`
** **External IPs**: `+https://example.com/alertmanager+`
** **LoadBalancer**: `+https://example.com/alertmanager+`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to fix the spelling mistakes.

Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenting
Copy link
Author

jenting commented Jul 22, 2020

Let's make CI happy~

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting
Copy link
Author

jenting commented Jul 28, 2020

@r0ckarong This is ready to review.

@r0ckarong r0ckarong self-assigned this Jul 29, 2020
@r0ckarong r0ckarong added this to the Sprint 35 milestone Jul 29, 2020
@r0ckarong r0ckarong merged commit a3d7a9b into SUSE:master Aug 3, 2020
r0ckarong pushed a commit that referenced this pull request Aug 3, 2020
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5.0 CaasP v5 release without Rancher AdminGuide Fix will change the Admin Guide Backport Change needs to be backported to a previous version indicated with label v4 CaaSP v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc] 6.1.3.2.4 Ingress - for grafana and prometheus needs to stay in helm chart and values!
4 participants