Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCP CPI enabled will disable hostname from DHCP #974

Merged
merged 1 commit into from
Oct 27, 2020
Merged

VCP CPI enabled will disable hostname from DHCP #974

merged 1 commit into from
Oct 27, 2020

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Aug 19, 2020 •
edited
Loading

Describe your changes

Address to fix in SUSE/skuba#1326 (comment).
When vSphere CPI enabled will automatically disable the VM hostname DHCP server assignment.

Related Issues / Projects

Please provide links to Bugzilla and other GitHub projects with your description if they are related to the changes.

Relates to: https://github.com/SUSE/avant-garde/issues/1817

@c3y1huang
VCP CPI enabled will disable hostname from DHCP
d991958 
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang added the DeploymentGuide Fix will change the Deployment Guide label Aug 19, 2020
@c3y1huang c3y1huang self-assigned this Aug 19, 2020
@r0ckarong
Copy link
Contributor

@jordimassaguerpla Which version release will this skuba change be in?

@r0ckarong r0ckarong self-assigned this Aug 21, 2020
@r0ckarong r0ckarong added this to the Sprint 36 milestone Aug 21, 2020
@innobead
Copy link
Contributor

@jordimassaguerpla Which version release will this skuba change be in?

It depends on if SUSE/skuba#1326 (comment) will be backported or not. Leave @cclhsu to discuss with the release group.

@r0ckarong r0ckarong added the Blocked Blocked by lack of information or external factors label Aug 24, 2020
@r0ckarong r0ckarong modified the milestones: Sprint 36, Sprint 37 Aug 26, 2020
@r0ckarong r0ckarong modified the milestones: Sprint 37, Sprint 38 Sep 8, 2020
@r0ckarong
Copy link
Contributor

r0ckarong commented Sep 8, 2020 •
edited
Loading

@innobead @cclhsu This has been backported now apparently, any updates if we can merge this for 4.5.1?

@innobead
Copy link
Contributor

innobead commented Sep 8, 2020

@innobead @cclhsu This has been backported now apparently, any updates if we can merge this for 4.5.1?

From my view, yes. But let @cclhsu help handle this. Thanks.

@cclhsu cclhsu added the 4.5.2 label Sep 9, 2020
@cclhsu
Copy link
Contributor

cclhsu commented Sep 9, 2020

I believe it was agreed on last Monday Release Coordination meeting to be included in 4.5.2.

@r0ckarong r0ckarong modified the milestones: Sprint 38, Sprint 40 Sep 17, 2020
@r0ckarong r0ckarong modified the milestones: Sprint 40, Sprint 41 Oct 13, 2020
@r0ckarong r0ckarong removed the Blocked Blocked by lack of information or external factors label Oct 22, 2020
@r0ckarong r0ckarong merged commit 9deb003 into SUSE:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@jenting jenting jenting approved these changes

@cclhsu cclhsu Awaiting requested review from cclhsu

@maximenoel8 maximenoel8 Awaiting requested review from maximenoel8

Assignees

@r0ckarong r0ckarong

@c3y1huang c3y1huang

Labels
4.5.2 DeploymentGuide Fix will change the Deployment Guide
Projects
None yet
Milestone
Sprint 41
Development

Successfully merging this pull request may close these issues.
5 participants
@c3y1huang @r0ckarong @innobead @cclhsu @jenting