Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert-exporter README #199

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Update cert-exporter README #199

merged 3 commits into from
Oct 15, 2020

Conversation

jenting
Copy link

@jenting jenting commented Sep 29, 2020

  • add example on how to monitor custom certificates
  • add helm2 and helm3 instruction commands
  • bump Chart version

xrefs SUSE/doc-caasp#1006

Signed-off-by: JenTing Hsiao jenting.hsiao@suse.com

@jenting
Copy link
Author

jenting commented Sep 29, 2020

cc @innobead @cclhsu @maximenoel8 PTAL

@jenting jenting changed the title Update README Update cert-exporter README Sep 29, 2020
- add example on how to monitor custom certificates
- add helm2 and helm3 instruction commands
- bump Chart version

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Copy link
Contributor

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@innobead
Copy link
Contributor

innobead commented Sep 30, 2020

@cclhsu please review and get it out after @maximenoel8 verifies. Thanks.

Copy link

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclhsu cclhsu merged commit 438a787 into SUSE:master Oct 15, 2020
@jenting jenting deleted the cert-exporter-examples branch October 15, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants