Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Run e2e jobs from pr #1094

Merged
merged 2 commits into from
May 8, 2020
Merged

Conversation

pablochacin
Copy link
Contributor

Why is this PR needed?

Facilitate test of daily jobs with changes introduced in a PR. For example, changes in the pipelines or changes in testrunner that may affect the CI.

Fixes https://github.com/SUSE/avant-garde/issues/1561

What does this PR do?

Configures the scm in daily jobs for using the BRANCH parameter and adds a refspe for pull requestss

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Pablo Chacin added 2 commits May 7, 2020 18:07
Job templates for daily jobs define a BRANCH parameter but their
scm specification ignores it.

Using the BRANCH parameter allows testing daily jobs using a branch.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Add the refspec to allow fetching pull requests
as branch pr/xxxx.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Copy link

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit c414d87 into SUSE:master May 8, 2020
jordimassaguerpla pushed a commit that referenced this pull request Jun 5, 2020
* Use branch from parameters in daily jobs

Using the BRANCH parameter allows testing daily jobs using a branch.

Add the refspec to allow fetching pull requests as branch pr/xxxx.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
mmnelemane pushed a commit to mmnelemane/skuba that referenced this pull request Jul 3, 2020
* Use branch from parameters in daily jobs

Using the BRANCH parameter allows testing daily jobs using a branch.

Add the refspec to allow fetching pull requests as branch pr/xxxx.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@pablochacin pablochacin deleted the run-e2e-jobs-from-pr branch July 10, 2020 10:27
mkoci-suse pushed a commit that referenced this pull request Feb 6, 2025
* Use branch from parameters in daily jobs

Using the BRANCH parameter allows testing daily jobs using a branch.

Add the refspec to allow fetching pull requests as branch pr/xxxx.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants