This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Set platform from pr label #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
added
ci-label:kvm
pablochacin
force-pushed
the
set-platform-from-pr-label
branch
3 times, most recently
from
6b29270 to
957d760
Compare
pablochacin
force-pushed
the
set-platform-from-pr-label
branch
from
2df896d to
813eee8
Compare
added 2 commits
May 22, 2020 16:34
If PR specifies a ci-platform label, override the default test platform. Signed-off-by: Pablo Chacin <pchacin@suse.com>
PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment. Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
force-pushed
the
set-platform-from-pr-label
branch
2 times, most recently
from
44521f9 to
46e238d
Compare
davidcassany
approved these changes
May 26, 2020
JanZerebecki
approved these changes
May 26, 2020
jordimassaguerpla
pushed a commit
that referenced
this pull request
Jun 5, 2020
Set platform from PR labels * If PR specifies a ci-platform label, override the default test platform. * PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment.
mmnelemane
pushed a commit
to mmnelemane/skuba
that referenced
this pull request
Jul 3, 2020
Set platform from PR labels * If PR specifies a ci-platform label, override the default test platform. * PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment.
pablochacin
pushed a commit
to pablochacin/skuba
that referenced
this pull request
Jul 9, 2020
Set platform from PR labels * If PR specifies a ci-platform label, override the default test platform. * PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment. (cherry picked from commit a5df22e)
mkoci-suse
pushed a commit
that referenced
this pull request
Feb 6, 2025
Set platform from PR labels * If PR specifies a ci-platform label, override the default test platform. * PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment.
mkoci-suse
pushed a commit
that referenced
this pull request
Feb 6, 2025
Set platform from PR labels * If PR specifies a ci-platform label, override the default test platform. * PR tests can run in any supported platoform. Add the configuration required by libvirt to the environment. (cherry picked from commit e7bf1b2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Some PR are specific to a platform. For example, CPI related PRs must be tested in the corresponding platform.
Fixes #
What does this PR do?
Sets the platform to the one specified in the
ci-platformlabel, if specified.Anything else a reviewer needs to know?
As only the workers labeled as
kvmcan run tests in thelibvirtplatform, the PR must also be labeled withci-label:libvirt.The execution shows the pipeline starts with the regular
caasp-team-private-integrationlabel and then thekvmlabel was added:Also, the provisioning step shows a
libvirtplatform was selected instead of the defaultvmwareplatform used for regular PR.Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: