-
Notifications
You must be signed in to change notification settings - Fork 56
Use experimental workers in PR #1125
Use experimental workers in PR #1125
Conversation
c2f3b3a
to
2e65688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com>
2e65688
to
ca53735
Compare
On second thought it would be more convenient to have the possibility to have multiple experimental workers so the PR will be modified accordingly. Please @chentex @JanZerebecki @davidcassany can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was thinking that maybe just working with the labels name should be enough, but then you can get multiple labels that could conflict on which workers to use, so I agree this will be a good solution to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com>
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com>
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com> (cherry picked from commit 3d6344a)
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com>
Some PR require experimental features that require workers with configurations that may conflict with regular workers. Signed-off-by: Pablo Chacin <pchacin@suse.com> (cherry picked from commit 6899d12)
Why is this PR needed?
Some PR require experimental features that require workers with configurations that may conflict with regular workers.
Fixes: #1125
What does this PR do?
Use a worker type based on the
ci-worker:<type>
label.Anything else a reviewer needs to know?
This PR should run on a worker labeled as
caasp-team-private-experimental
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: