Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Use experimental workers in PR #1125

Merged
merged 1 commit into from
May 28, 2020

Conversation

pablochacin
Copy link
Contributor

@pablochacin pablochacin commented May 27, 2020

Why is this PR needed?

Some PR require experimental features that require workers with configurations that may conflict with regular workers.

Fixes: #1125

What does this PR do?

Use a worker type based on the ci-worker:<type> label.

Anything else a reviewer needs to know?

This PR should run on a worker labeled as caasp-team-private-experimental

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

@pablochacin pablochacin added the ci-worker:experimental Use experimental worker label May 27, 2020
@pablochacin pablochacin marked this pull request as draft May 27, 2020 10:04
@pablochacin pablochacin marked this pull request as ready for review May 27, 2020 21:01
@pablochacin pablochacin force-pushed the use-experimental-worker-in-pr branch from c2f3b3a to 2e65688 Compare May 28, 2020 07:57
chentex
chentex previously approved these changes May 28, 2020
Copy link

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JanZerebecki
JanZerebecki previously approved these changes May 28, 2020
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
@pablochacin pablochacin dismissed stale reviews from JanZerebecki and chentex via ca53735 May 28, 2020 08:46
@pablochacin pablochacin force-pushed the use-experimental-worker-in-pr branch from 2e65688 to ca53735 Compare May 28, 2020 08:46
@pablochacin
Copy link
Contributor Author

On second thought it would be more convenient to have the possibility to have multiple experimental workers so the PR will be modified accordingly. Please @chentex @JanZerebecki @davidcassany can you review it again?

Copy link

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I was thinking that maybe just working with the labels name should be enough, but then you can get multiple labels that could conflict on which workers to use, so I agree this will be a good solution to this

Copy link
Collaborator

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit 3d6344a into SUSE:master May 28, 2020
jordimassaguerpla pushed a commit that referenced this pull request Jun 5, 2020
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
mmnelemane pushed a commit to mmnelemane/skuba that referenced this pull request Jul 3, 2020
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin pushed a commit to pablochacin/skuba that referenced this pull request Jul 9, 2020
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
(cherry picked from commit 3d6344a)
@pablochacin pablochacin deleted the use-experimental-worker-in-pr branch July 10, 2020 10:27
mkoci-suse pushed a commit that referenced this pull request Feb 6, 2025
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
mkoci-suse pushed a commit that referenced this pull request Feb 6, 2025
Some PR require experimental features that require workers
with configurations that may conflict with regular workers.

Signed-off-by: Pablo Chacin <pchacin@suse.com>
(cherry picked from commit 6899d12)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants