This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Fix quotes in label to allow variable substitution #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use double quotes in worker label to allow for variable substitution. Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
force-pushed
the
fix-label-variable-substitution
branch
from
f3a4cc9 to
7e0e1a3
Compare
JanZerebecki
approved these changes
Jun 3, 2020
jordimassaguerpla
approved these changes
Jun 3, 2020
davidcassany
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
After changes introduced in #1129 worker labels are not properly setup
What does this PR do?
Use double quotes in worker labels to allow for variable substitution.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: