Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Fix typo in configuration comment #1149

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix typo in configuration comment #1149

merged 1 commit into from
Jun 16, 2020

Conversation

dirkmueller
Copy link
Member

@dirkmueller dirkmueller commented Jun 10, 2020

The files are supposed to be in /etc/crio/crio.conf.d/ not
/etc/crio/conf.d/. Also cleanup wording a bit.

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

What does this PR do?

please include a brief "management" technical overview (details are in the code)

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

Info that can be relevant for QA:

  • link to other PRs that should be merged together
  • link to packages that should be released together
  • upstream issues

Status BEFORE applying the patch

The README generated in skuba init process step pointed to a file / directory location that does not exist.

Status AFTER applying the patch

The README generated in skuba init process step points to an existing directory.

Docs

Docs do not need to be updated because they do not carry this typo.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

@suseclee suseclee requested a review from jenting June 10, 2020 16:50
suseclee
suseclee previously approved these changes Jun 10, 2020
Copy link
Contributor

@suseclee suseclee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suseclee
Copy link
Contributor

Sorry. @jenting I accidentally clicked re-request review circle on the top right.

jenting
jenting previously approved these changes Jun 11, 2020
The files are supposed to be in /etc/crio/crio.conf.d/ not
/etc/crio/conf.d/. Also cleanup wording a bit.
@dirkmueller dirkmueller dismissed stale reviews from jenting and suseclee via f33c43b June 11, 2020 08:58
@fgerling fgerling self-requested a review June 16, 2020 14:04
Copy link

@fgerling fgerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a QA perspective, this looks reasonable. Thank you.

@JanZerebecki JanZerebecki merged commit 5ce3e27 into SUSE:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants