This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Remove pr-test-libvirt job #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pipeline has duplicated logic with respect of pr-test. pr-test now includes additional pr validation logic that makes no sense to duplicate in the pr-test-libvirt job. The whole pr-test-libvirt pipeline must be reconsidered. Signed-off-by: Pablo Chacin <pchacin@suse.com>
jordimassaguerpla
approved these changes
Jun 12, 2020
mmnelemane
pushed a commit
to mmnelemane/skuba
that referenced
this pull request
Jul 3, 2020
This pipeline has duplicated logic with respect of pr-test. pr-test now includes additional pr validation logic that makes no sense to duplicate in the pr-test-libvirt job. The whole pr-test-libvirt pipeline must be reconsidered. Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
added a commit
to pablochacin/skuba
that referenced
this pull request
Jul 9, 2020
This pipeline has duplicated logic with respect of pr-test. pr-test now includes additional pr validation logic that makes no sense to duplicate in the pr-test-libvirt job. The whole pr-test-libvirt pipeline must be reconsidered. Signed-off-by: Pablo Chacin <pchacin@suse.com> (cherry picked from commit 2068489)
mkoci-suse
pushed a commit
that referenced
this pull request
Feb 6, 2025
This pipeline has duplicated logic with respect of pr-test. pr-test now includes additional pr validation logic that makes no sense to duplicate in the pr-test-libvirt job. The whole pr-test-libvirt pipeline must be reconsidered. Signed-off-by: Pablo Chacin <pchacin@suse.com> (cherry picked from commit 9aedd44)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
This pipeline has duplicated logic with respect of pr-test.
pr-test now includes additional pr validation logic that makes no sense
to duplicate in the pr-test-libvirt job.
What does this PR do?
Removes the pr-test-libvirt job and the corresponding pipeline.
Anything else a reviewer needs to know?
The pr-test-libvirt must be manually removed from jenkins. Merging this PR will not automatically remove it.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: