This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Update sonobuoy version #1164
Merged
Update sonobuoy version #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
force-pushed
the
update-sonobuoy-version
branch
2 times, most recently
from
84973df to
ead9233
Compare
dirkmueller
reviewed
Jun 15, 2020
Pass sonobuoy versio as a paramter to conformace tests. Update sonobuoy version for master branch to one that supports k8s 1.18 Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
force-pushed
the
update-sonobuoy-version
branch
from
ead9233 to
9760deb
Compare
Signed-off-by: Pablo Chacin <pchacin@suse.com>
|
Do we have to update the sonobuoy package in Devel:CaaSP:5 ? |
|
no, 1.18.2 is already in Devel:CaaSP:5. ideally somebody would review ibs rq 220338 though and then this could refer to the latest version instead. |
pablochacin
requested review from
JanZerebecki,
davidcassany and
jordimassaguerpla
jordimassaguerpla
approved these changes
Jun 16, 2020
JanZerebecki
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Conformance tests are failing with error:
The maximum supported Kubernetes version is 1.17.99, but the server version is v1.18.2. Sonobuoy will continue but unexpected results may occur.Fixes https://github.com/SUSE/avant-garde/issues/1708
What does this PR do?
Pass sonobuoy versio as a paramter to conformace tests.
Update sonobuoy version for master branch to one that supports k8s 1.18
Removes unnecessary checkout logic in the pipeline that prevents testing against the job agains a pr branch.
Note to reviewers
The PR was tested running the conformance test job against the pr branch
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: