Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Fix the branched repo url #1177

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

davidcassany
Copy link
Collaborator

Why is this PR needed?

The URL for the branched repo is pointing to a wrong OBS repository,
for CaaSPv5 instead of SLE_15_SP1 we are using SLE_15_SP2.

What does this PR do?

Update the URL to make use of SLE_15_SP2

The URL for the branched repo is pointing to a wrong OBS repository,
for CaaSPv5 instead of SLE_15_SP1 we are using SLE_15_SP2.
@davidcassany
Copy link
Collaborator Author

@pablochacin we could create a new constant variable for the repository too, as we do for the CaaSP version. However I do not have a strong opinion on that, whatever we do will be hardcoded.

@jordimassaguerpla probably we could even consider using standard instead of SLE_15_SP2 so we do not have to update it for every CaaSP version, minor details anyway.

@jordimassaguerpla
Copy link
Member

@pablochacin we could create a new constant variable for the repository too, as we do for the CaaSP version. However I do not have a strong opinion on that, whatever we do will be hardcoded.

@jordimassaguerpla probably we could even consider using standard instead of SLE_15_SP2 so we do not have to update it for every CaaSP version, minor details anyway.

I think is a good idea. standard is also the name used in SUSE....CaaSP:5

@davidcassany
Copy link
Collaborator Author

I think is a good idea. standard is also the name used in SUSE....CaaSP:5

Great, so I'd say lets go now for SLE_15_SP2 approach (consistent with what we have) and create a card to run the change, I don't know now in how many places we would have to run the change, so better to do it in an organized way.

@pablochacin
Copy link
Contributor

The problem I see is that this change would break v4. As this branches is not sync, this will not be inmediate, but if we backport this change to v4, it will break.

@davidcassany
Copy link
Collaborator Author

Ok I just added a follow up card to handle the maintainability issue

SUSE/avant-garde#1738

@davidcassany davidcassany merged commit 0519651 into SUSE:master Jun 22, 2020
@davidcassany davidcassany deleted the fix_branched_repo_url branch June 22, 2020 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants