Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

[terraform] fix mtu from 1400 to standard 1500 #1181

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[terraform] fix mtu from 1400 to standard 1500 #1181

merged 1 commit into from
Jun 23, 2020

Conversation

spiarh
Copy link
Contributor

@spiarh spiarh commented Jun 22, 2020

Why is this PR needed?

This is probably a leftover form developement, there is no need to set the MTU to 1400.

On AWS, it is required otherwise we get 9001 MTU.

Signed-off-by: lcavajani lcavajani@suse.com

What does this PR do?

set MTU to 1500 on AWS and use the default with libvirt and openstack

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

ip link show eth0 should show 1500 for all platforms unless there is a specific configuration.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

This is probably a leftover form developement,
there is no need to set the MTU to 1400.

On AWS, it is required otherwise we get 9001 MTU.

Signed-off-by: lcavajani <lcavajani@suse.com>
@spiarh spiarh changed the title [terraform] fix mtu [terraform] fix mtu set to 1400 Jun 22, 2020
@spiarh spiarh added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 22, 2020
@spiarh spiarh changed the title [terraform] fix mtu set to 1400 [terraform] fix mtu set from 1400 to standard 1500 Jun 23, 2020
@spiarh spiarh changed the title [terraform] fix mtu set from 1400 to standard 1500 [terraform] fix mtu from 1400 to standard 1500 Jun 23, 2020
Copy link
Contributor

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead innobead merged commit 022183c into SUSE:master Jun 23, 2020
@spiarh spiarh deleted the remove_mtu branch June 24, 2020 10:57
mmnelemane pushed a commit to mmnelemane/skuba that referenced this pull request Jul 3, 2020
This is probably a leftover form developement,
there is no need to set the MTU to 1400.

On AWS, it is required otherwise we get 9001 MTU.

Signed-off-by: lcavajani <lcavajani@suse.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants