Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Switch to SLE15-SP2 base images and change references to v5 #1207

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Switch to SLE15-SP2 base images and change references to v5 #1207

merged 1 commit into from
Jul 2, 2020

Conversation

dirkmueller
Copy link
Member

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

What does this PR do?

please include a brief "management" technical overview (details are in the code)

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

spec:
containers:
- name: app
image: registry.suse.de/suse/containers/sle-server/15/containers/suse/sle15:15.2
command: ['/bin/sh', '-c', 'sleep 3600']"""
Copy link

@jenting jenting Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
command: ['/bin/sh', '-c', 'sleep 3600']"""
command: ['/bin/sh', '-c', 'sleep 3600']
"""

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is changing how it was done before. I personally don't really care either way, but I need to update commit message, or create a separate PR for it, or convince that the end-of-file style with newline is better in some regard.

I have very little energy for this.

jenting
jenting previously approved these changes Jul 2, 2020
@jordimassaguerpla
Copy link
Member

@jenting This was rebased. If you could review it again, then Dirk could merge it and we will include this in the skuba package for RC1.

@dirkmueller dirkmueller merged commit b1e2124 into SUSE:master Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants