This repository was archived by the owner on Feb 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Switch to SLE15-SP2 base images and change references to v5 #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordimassaguerpla
previously approved these changes
Jun 30, 2020
jenting
reviewed
Jul 1, 2020
jenting
reviewed
Jul 2, 2020
spec: | ||
containers: | ||
- name: app | ||
image: registry.suse.de/suse/containers/sle-server/15/containers/suse/sle15:15.2 | ||
command: ['/bin/sh', '-c', 'sleep 3600']""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Suggested change
command: ['/bin/sh', '-c', 'sleep 3600']""" | |
command: ['/bin/sh', '-c', 'sleep 3600'] | |
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is changing how it was done before. I personally don't really care either way, but I need to update commit message, or create a separate PR for it, or convince that the end-of-file style with newline is better in some regard.
I have very little energy for this.
jenting
previously approved these changes
Jul 2, 2020
jordimassaguerpla
suggested changes
Jul 2, 2020
jordimassaguerpla
approved these changes
Jul 2, 2020
@jenting This was rebased. If you could review it again, then Dirk could merge it and we will include this in the skuba package for RC1. |
jenting
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Does it fix an issue? addresses a business case?
add a description and link to the issue if one exists.
Fixes #
Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.
What does this PR do?
please include a brief "management" technical overview (details are in the code)
Anything else a reviewer needs to know?
Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: