Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Avoid pulling plugins from the Terraform online repositry #1213

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Avoid pulling plugins from the Terraform online repositry #1213

merged 1 commit into from
Jul 6, 2020

Conversation

dirkmueller
Copy link
Member

@dirkmueller dirkmueller commented Jun 30, 2020

We'd like to test what we ship, so we should not allow terraform
to pull from the online repository additional plugins, as that would
hide issues in the state that we're trying to test in the CI.

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes https://github.com/SUSE/avant-garde/issues/1759

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

What does this PR do?

See commit message.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

We'd like to test what we ship, so we should not allow terraform
to pull from the online repository additional plugins, as that would
hide issues in the state that we're trying to test in the CI.
Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirkmueller dirkmueller merged commit 7d49333 into SUSE:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants