This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Add option for skipping cleanup to e2e test pipeline #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
force-pushed
the
pause-failed-e2e-test
branch
3 times, most recently
from
ac4b04e to
d61b75e
Compare
dirkmueller
changed the title
pablochacin
force-pushed
the
pause-failed-e2e-test
branch
from
d61b75e to
cae58ec
Compare
pablochacin
force-pushed
the
pause-failed-e2e-test
branch
19 times, most recently
from
7901344 to
d9a0206
Compare
pablochacin
changed the title
pablochacin
force-pushed
the
pause-failed-e2e-test
branch
from
d9a0206 to
a4c7b2d
Compare
Itxaka
previously approved these changes
Jul 8, 2020
JanZerebecki
previously approved these changes
Jul 8, 2020
added 2 commits
July 9, 2020 10:38
If job fails and cluster retantion is requested, wait for a confirmation or until a maximun retention period before cleanup. Signed-off-by: Pablo Chacin <pchacin@suse.com>
Add parameters for retaining the cluster in case of failure in the test. Remove timeout from job to prevent job to be cancelled while waiting the retention period. Enable concurrent executions to allow running the job while a previous build is waiting the retention period. Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
force-pushed
the
pause-failed-e2e-test
branch
from
b592317 to
193a64c
Compare
Itxaka
approved these changes
Jul 9, 2020
JanZerebecki
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
To ease debugging failures in the tests
Fixes https://github.com/SUSE/avant-garde/issues/1755
What does this PR do?
Add option for skipping the cleanup of a job in case of failure and resume it later for completing the cleanup.
Anything else a reviewer needs to know?
This PR was tested running the e2e test with the PR branch
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: