-
Notifications
You must be signed in to change notification settings - Fork 56
Add Resource Groups + AZ filter for AWS tf #1225
Conversation
Signed-off-by: lcavajani <lcavajani@suse.com>
Signed-off-by: lcavajani <lcavajani@suse.com>
Since the PR was still open an not too fat, I'ved added support to filter the Availability Zones. |
Signed-off-by: lcavajani <lcavajani@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @maximenoel8 @thehejik better to have a review and regression. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please open a bug for that and submit some documentation for that (if you can, I would love that). Thanks for yet another great submission 💚 |
* Add resourcegroup in AWS tf Signed-off-by: lcavajani <lcavajani@suse.com> * Add AZ filter in AWS tf Signed-off-by: lcavajani <lcavajani@suse.com> * add az filter in tfvars example Signed-off-by: lcavajani <lcavajani@suse.com>
* Add resourcegroup in AWS tf Signed-off-by: lcavajani <lcavajani@suse.com> * Add AZ filter in AWS tf Signed-off-by: lcavajani <lcavajani@suse.com> * add az filter in tfvars example Signed-off-by: lcavajani <lcavajani@suse.com>
backport #1319 |
…ckport_4_5_0 Add Resource Groups + AZ filter for AWS tf (#1225)
Does this impact the terraform examples in the docs? https://github.com/SUSE/doc-caasp/blob/master/adoc/deployment-terraform-example.adoc |
Why is this PR needed?
Quoting official documentation:
It is required for a user to have the following permissions:
What does this PR do?
If all the regions are working correctly and the operator uses the region
eu-west-3
.With the default filter, the availability zone selected will be the first one in the list so
eu-west-3-a
.If the operator defines the following variable:
Then the
subnet
will be created ineu-west-3c
Docs
There is currently no doc about the required IAM permission for the operator in the doc (only for instance profiles).
cc @nkoranova @r0ckarong do you have something on your side regarding this topic ? otherwise I will open a bug.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: