This repository was archived by the owner on Feb 6, 2025. It is now read-only.
CI: Unify platform configuration #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make images defined in the terraform.tfvars.json.ci.example file for all platforms, not as environment variables or in the testrunner's configuration file. Signed-off-by: Pablo Chacin <pchacin@suse.com>
pablochacin
force-pushed
the
unify-platform-configuration-in-ci
branch
from
f0b0de8 to
b270b97
Compare
jordimassaguerpla
approved these changes
Jul 10, 2020
Itxaka
approved these changes
Jul 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
Presently, the way images used in different platforms is defined in an inconsistent way: some in tfvars files, others in environment variable (libvirt). Also, some can be overridden from the testrunner's configuration, while others no.
What does this PR do?
Make images defined in the terraform.tfvars.json.ci.example file for all platforms, not as environment variables or in the testrunner's configuration file.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: