New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed the example of generating XML (Standard Invoice) in README #10

Merged

Saleh7 merged 2 commits into Saleh7:main from sevaske:fix-readme-md

Feb 18, 2025

Contributor

sevaske commented Feb 18, 2025

There was an error in generating the XML file. The corrected version:
$generatorXml = GeneratorInvoice::invoice($invoice);
$outputXML = $generatorXml->getXML();
I checked the generated XML in the validator https://sandbox.zatca.gov.sa/TestXML, and it had one error and 2-3 warnings. With my changes, the XML is now fully valid.

sevaske added 2 commits

February 18, 2025 12:33


          fix: Fixed the example of generating XML (Standard Invoice) in README…

fd09c77

….md #fix-readme-md


          fix: Fixed the example of generating XML (Standard Invoice) in README…

b8af337

….md (missed changes) #fix-readme-md

Contributor Author

sevaske commented Feb 18, 2025

screenshot of the xml validation

Saleh7 merged commit e42d8c5 into Saleh7:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet